From 2353bff721c03ab028c615a6280eb56170ec55f3 Mon Sep 17 00:00:00 2001 From: Andrew Tritt Date: Mon, 17 May 2021 19:48:41 -0400 Subject: [PATCH 1/2] override for less than 1.8 --- pytorch_lightning/overrides/torch_distributed.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pytorch_lightning/overrides/torch_distributed.py b/pytorch_lightning/overrides/torch_distributed.py index 67b64c046dc18..ebee83828e0d7 100644 --- a/pytorch_lightning/overrides/torch_distributed.py +++ b/pytorch_lightning/overrides/torch_distributed.py @@ -3,7 +3,7 @@ import torch -from pytorch_lightning.utilities.imports import _TORCH_GREATER_EQUAL_1_7 +from pytorch_lightning.utilities.imports import _TORCH_GREATER_EQUAL_1_8 log = logging.getLogger(__name__) @@ -88,7 +88,7 @@ def _broadcast_object_list(object_list, src=0, group=None): object_list[i] = _tensor_to_object(obj_view, obj_size) -if _TORCH_GREATER_EQUAL_1_7 and torch.distributed.is_available(): +if _TORCH_GREATER_EQUAL_1_8 and torch.distributed.is_available(): from torch.distributed.distributed_c10d import broadcast_object_list else: broadcast_object_list = _broadcast_object_list From cc93a945b359814c2c4b44faf811f0ca5e6230da Mon Sep 17 00:00:00 2001 From: Carlos Mocholi Date: Thu, 20 May 2021 00:06:39 +0200 Subject: [PATCH 2/2] Update CHANGELOG --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 82ce08594b310..f11ea9029f930 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -93,6 +93,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). - Fixed parsing of multiple training dataloaders ([#7433](https://github.com/PyTorchLightning/pytorch-lightning/pull/7433)) +- Fixed broadcasting in multi-node, multi-gpu DDP using torch 1.7 ([#7592](https://github.com/PyTorchLightning/pytorch-lightning/pull/7592)) + + - Fixed recursive passing of `wrong_type` keyword argument in `pytorch_lightning.utilities.apply_to_collection` ([#7433](https://github.com/PyTorchLightning/pytorch-lightning/pull/7433))