Skip to content

Weekly Patch Release v1.3.2 [full merge, no squash] #7589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2021
Merged

Weekly Patch Release v1.3.2 [full merge, no squash] #7589

merged 5 commits into from
May 19, 2021

Conversation

@edgarriba
Copy link
Contributor

@edgarriba edgarriba commented May 18, 2021 •
edited by Borda
Loading

What does this PR do?

related to #7467

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca @awaelchli @edgarriba
Automatically check DataModule.has_{setup,teardown,prepare_data} [2…
25115a1 
…/2] (#7238)

* Automatically check `DataModule.has_{setup,teardown,prepare_data}`

* Use variable

* Spacing

* Docs

* Update CHANGELOG

* Remove `_DataModuleWrapper`

* Add test

* Update docs/source/extensions/datamodules.rst

* Bad merge

* add test for invalid name

* Remove ValueError

Co-authored-by: Adrian Wälchli <[email protected]>
@codecov
Copy link

codecov bot commented May 18, 2021 •
edited
Loading

Codecov Report

Merging #7589 (c2b8eae) into release/1.3.x (b9b3ec5) will decrease coverage by 4%.
The diff coverage is 89%.

@@              Coverage Diff               @@
##           release/1.3.x   #7589    +/-   ##
==============================================
- Coverage             92%     87%    -4%     
==============================================
  Files                200     200            
  Lines              12993   13004    +11     
==============================================
- Hits               11922   11367   -555     
- Misses              1071    1637   +566

@Borda Borda changed the base branch from master to release/1.3.x May 18, 2021 13:51
@Borda Borda changed the title V1.3.2 Weekly Patch Release v1.3.2 [full merge, no squash] May 18, 2021
@Lightning-AI Lightning-AI deleted a comment from pep8speaks May 18, 2021
@pep8speaks
Copy link

pep8speaks commented May 18, 2021 •
edited
Loading

Hello @edgarriba! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-18 14:15:08 UTC

@Borda Borda mentioned this pull request May 18, 2021
Closed
@carmocca carmocca added this to the v1.3.x milestone May 18, 2021
carmocca
carmocca reviewed May 18, 2021
View reviewed changes
carmocca
carmocca reviewed May 18, 2021
View reviewed changes
alanhdu and others added 4 commits May 18, 2021 16:14
@alanhdu @Borda
Fix DistribType for ddp_cpu (spawn) (#7492)
5112e56
@tkng @awaelchli
@pre-commit-ci @Borda
Fix the condition for calling update_learning_rates (#7032)
80992e6 
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@justusschock @awaelchli
@pre-commit-ci @akihironitta @edgarriba @carmocca @Borda
Bugfix/Multiple dataloaders (#7433)
c627040 
* Update supporters.py

* Update apply_func.py

* Update supporters.py

* Update model_train_dataloaders.py

* Update model_train_steps.py

* Update test_dataloaders.py

* Update CHANGELOG.md

* Update model_train_steps.py

* Update test_dataloaders.py

* Update test_dataloaders.py

* Update supporters.py

* Update test_supporters.py

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update tests/trainer/test_dataloaders.py

Co-authored-by: Akihiro Nitta <[email protected]>

* Apply suggestions from code review

Co-authored-by: Edgar Riba <[email protected]>

* Update supporters.py

* Update supporters.py

* Apply suggestions from code review

Co-authored-by: Carlos Mocholí <[email protected]>

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Edgar Riba <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@edgarriba @Borda
v1.3.2
c2b8eae
Borda
Borda approved these changes May 18, 2021
View reviewed changes
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done :]

@Borda Borda marked this pull request as ready for review May 18, 2021 14:15
@Borda Borda requested a review from carmocca May 18, 2021 14:16
@Borda Borda added the ready PRs ready to be merged label May 18, 2021
@lexierule lexierule merged commit 6b81cd8 into release/1.3.x May 19, 2021
@lexierule lexierule deleted the v1.3.2 branch May 19, 2021 19:21
This was referenced May 25, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@ananthsub ananthsub Awaiting requested review from ananthsub

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.3.x

Development

Successfully merging this pull request may close these issues.