Skip to content

Conversation

@gianscarpe
Copy link
Contributor

@gianscarpe gianscarpe commented May 13, 2021

What does this PR do?

Workin on issue #6030
@awaelchli

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

…plicitely set train_dataloader from datamodule (if available). confg_validation checks if datamodule is available and eventually check datamodule.train_dataloader is overridden
@pep8speaks
Copy link

pep8speaks commented May 13, 2021

Hello @gianscarpe! Thanks for updating this PR.

Line 246:121: E501 line too long (140 > 120 characters)

Comment last updated at 2021-05-13 08:55:55 UTC

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #7522 (e30ec01) into release/1.3.x (b9b3ec5) will decrease coverage by 48%.
The diff coverage is 9%.

@@               Coverage Diff               @@
##           release/1.3.x   #7522     +/-   ##
===============================================
- Coverage             92%     43%    -48%     
===============================================
  Files                200     200             
  Lines              12993   12998      +5     
===============================================
- Hits               11922    5650   -6272     
- Misses              1071    7348   +6277     

@gianscarpe
Copy link
Contributor Author

@awaelchli I rebased on release 1.3.x. Actually I need to re-take this as it's been a few months since my last commit

@Borda Borda changed the title Fix6030/avoid patching avoid patching May 13, 2021
@awaelchli awaelchli added data handling Generic data-related topic feature Is an improvement or enhancement refactor labels May 15, 2021
@awaelchli awaelchli added this to the v1.4 milestone May 15, 2021
@edenlightning edenlightning modified the milestones: v1.4, v1.5 Jul 9, 2021
@rohitgr7
Copy link
Contributor

@awaelchli shall we close this one?

@awaelchli
Copy link
Contributor

Yes
@gianscarpe did a great job starting here but we didn't understand the complexity fully back then, and now the PR is quite conflicted. Closing in favor of #9764

@awaelchli awaelchli closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data handling Generic data-related topic feature Is an improvement or enhancement refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants