-
Notifications
You must be signed in to change notification settings - Fork 3.6k
avoid patching #7522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid patching #7522
Conversation
…plicitely set train_dataloader from datamodule (if available). confg_validation checks if datamodule is available and eventually check datamodule.train_dataloader is overridden
…amodule has the precedence
|
Hello @gianscarpe! Thanks for updating this PR.
Comment last updated at 2021-05-13 08:55:55 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## release/1.3.x #7522 +/- ##
===============================================
- Coverage 92% 43% -48%
===============================================
Files 200 200
Lines 12993 12998 +5
===============================================
- Hits 11922 5650 -6272
- Misses 1071 7348 +6277 |
|
@awaelchli I rebased on release 1.3.x. Actually I need to re-take this as it's been a few months since my last commit |
|
@awaelchli shall we close this one? |
|
Yes |
What does this PR do?
Workin on issue #6030
@awaelchli
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃