Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented May 11, 2021

What does this PR do?

see #7467

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

leezu and others added 6 commits May 11, 2021 09:17
* deepspeed add train_micro_batch_size_per_gpu argument

* Update naming and doc

* Modify to use auto naming convention, add test

* Add iterable tests

* Fix tests, attempt by mocking

* Import correct package

* Fix comparison

* Set as special test

* Remove import

* Add Changelog

Co-authored-by: SeanNaren <[email protected]>

(cherry picked from commit 98b94b8)
(cherry picked from commit 1a27c12)
* Add a test

* Save and restore current_epoch

* Update CHANGELOG

* alphabetical order

(cherry picked from commit 710b144)
(cherry picked from commit 1af42d7)
(cherry picked from commit 6bc616d)
* Dont use sphinx 4.0.0

* Dont use sphinx 4.0.0

* Update comment

* Simple

There is no other release between 3.5 and 4.0

Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit 6d82dc8)
@Borda Borda requested a review from edenlightning as a code owner May 11, 2021 07:17
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #7477 (13cbfd0) into rrelease/1.3.x (fbc8b20) will decrease coverage by 48%.
The diff coverage is 20%.

❗ Current head 13cbfd0 differs from pull request most recent head 4eaae47. Consider uploading reports for the commit 4eaae47 to get more accurate results

@@               Coverage Diff                @@
##           rrelease/1.3.x   #7477     +/-   ##
================================================
- Coverage              92%     43%    -48%     
================================================
  Files                 200     200             
  Lines               12983   12990      +7     
================================================
- Hits                11937    5649   -6288     
- Misses               1046    7341   +6295     

@Borda Borda merged commit b9b3ec5 into rrelease/1.3.x May 11, 2021
@Borda Borda deleted the v1.3.1 branch May 11, 2021 08:28
@carmocca carmocca mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants