-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[3 / 3] improvements to saving and loading callback state #7161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @awaelchli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-28 22:21:18 UTC |
Codecov Report
@@ Coverage Diff @@
## master #7161 +/- ##
=======================================
+ Coverage 88% 92% +4%
=======================================
Files 176 175 -1
Lines 14649 14667 +18
=======================================
+ Hits 12875 13501 +626
+ Misses 1774 1166 -608 |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
6afe6c3 to
d20b4f4
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
d20b4f4 to
2620069
Compare
f8f746e to
e775881
Compare
6fe4a5b to
9ddb211
Compare
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
Co-authored-by: Carlos Mocholí <[email protected]>
This reverts commit 8ad08ca.
What does this PR do?
Part of #6467
Follow up to #6886 and #7187
Also:
Fixes #8833
Several cleanups to handle a warning message properly after the changes in #7187.
Before submitting
NOT NEEDED because the changes were only introduced in master.
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃