-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update test for ckpt+val_check_interval #7084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
tchaton
approved these changes
Apr 19, 2021
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch !
carmocca
approved these changes
Apr 19, 2021
Codecov Report
@@ Coverage Diff @@
## master #7084 +/- ##
======================================
- Coverage 92% 92% -0%
======================================
Files 197 197
Lines 12634 12677 +43
======================================
+ Hits 11649 11666 +17
- Misses 985 1011 +26 |
rohitgr7
commented
Apr 20, 2021
awaelchli
approved these changes
Apr 20, 2021
Borda
approved these changes
Apr 20, 2021
Collaborator
Borda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While reviewing #7032, noticed that this test is a bit incorrect since with total train batches=12 and val_check_interval=0.33, actual batch interval = 4 which aligns with the train_loop perfectly. In the test, we need to check for the case where val_check_interval doesn't align train batches, so updated the test here.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃