Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Apr 18, 2021

What does this PR do?

While reviewing #7032, noticed that this test is a bit incorrect since with total train batches=12 and val_check_interval=0.33, actual batch interval = 4 which aligns with the train_loop perfectly. In the test, we need to check for the case where val_check_interval doesn't align train batches, so updated the test here.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 marked this pull request as ready for review April 18, 2021 12:35
@awaelchli awaelchli added checkpointing Related to checkpointing ci Continuous Integration labels Apr 18, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #7084 (dbe0f78) into master (d12c6cf) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7084   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         197     197           
  Lines       12634   12677   +43     
======================================
+ Hits        11649   11666   +17     
- Misses        985    1011   +26     

Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Borda Borda merged commit 14e6b46 into master Apr 20, 2021
@Borda Borda deleted the tests/vci_ckpt branch April 20, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

checkpointing Related to checkpointing ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants