Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Apr 9, 2021

What does this PR do?

TBS

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the feature Is an improvement or enhancement label Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #6931 (606e30b) into master (e9c3e02) will decrease coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #6931    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         194     194            
  Lines       12346   12346            
=======================================
- Hits        11327   10719   -608     
- Misses       1019    1627   +608     

@Borda Borda marked this pull request as ready for review April 10, 2021 22:17
@Borda Borda requested a review from tchaton as a code owner April 10, 2021 22:17
@Borda Borda requested review from a team, SeanNaren and carmocca April 10, 2021 22:18
@Borda Borda enabled auto-merge (squash) April 12, 2021 14:09
@Borda Borda changed the title update docker base on PT 1.7 update docker base Apr 12, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me 😃

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit da1ac3a into master Apr 13, 2021
@Borda Borda deleted the docker/nvidia branch April 13, 2021 09:06
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
* update docker base on PT 1.7

* fix path

(cherry picked from commit da1ac3a)
@SeanNaren SeanNaren mentioned this pull request Apr 13, 2021
awaelchli pushed a commit that referenced this pull request Apr 13, 2021
* update docker base on PT 1.7

* fix path

(cherry picked from commit da1ac3a)
lexierule pushed a commit that referenced this pull request Apr 14, 2021
* update docker base on PT 1.7

* fix path

(cherry picked from commit da1ac3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Is an improvement or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants