-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Set find unused parameters to True by default to fix breaking compatibility #6438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add suggestion to re-enable
justusschock
approved these changes
Mar 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #6438 +/- ##
======================================
Coverage 94% 94%
======================================
Files 161 161
Lines 11495 11495
======================================
Hits 10751 10751
Misses 744 744 |
carmocca
approved these changes
Mar 9, 2021
Closed
ananthsub
approved these changes
Mar 9, 2021
awaelchli
approved these changes
Mar 10, 2021
Contributor
awaelchli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I linked two more issues
This was referenced Mar 17, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
distributed
Generic distributed-related topic
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6219
Fixes #5799
Fixes #6409
Fixes #5604
A lot of back and forth here, but we're making a trade off for compatability/speed. This PR suggests setting the default to True, and adding into the documentation to set this parameter to False for speed.
As always I suggest checking Sharded Training, which does not have the same issue!
cc @ananthsub @ericharper @tchaton @carmocca @awaelchli @justusschock
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃