fix logger creating directory structure too early in DDP #6380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6380 +/- ##
=======================================
- Coverage 94% 90% -3%
=======================================
Files 161 161
Lines 11497 11388 -109
=======================================
- Hits 10753 10284 -469
- Misses 744 1104 +360 |
awaelchli
requested review from
Borda,
SeanNaren,
carmocca,
justusschock,
tchaton and
williamFalcon
as code owners
carmocca
approved these changes
Mar 7, 2021
Contributor
carmocca
left a comment
carmocca
left a comment
There was a problem hiding this comment.
Great! Does the test fail in current master?
Contributor
Author
|
@carmocca yes, it fails on master :) |
ananthsub
approved these changes
Mar 7, 2021
s-rog
approved these changes
Mar 8, 2021
Borda
approved these changes
Mar 8, 2021
justusschock
approved these changes
Mar 8, 2021
tchaton
approved these changes
Mar 9, 2021
| def pre_dispatch(self): | ||
| self.accelerator.pre_dispatch() | ||
|
|
||
| # log hyper-parameters |
Contributor
There was a problem hiding this comment.
Can we wrap this into a function ?
Closed
SeanNaren
pushed a commit
that referenced
this pull request
Mar 16, 2021
* fix * add simple test * fix imports * add changelog * tighter test with on_fit_start hook closer to the dispatch call * move class inside test f unction * add a comment (cherry picked from commit fc6d402)
lexierule
pushed a commit
that referenced
this pull request
Mar 16, 2021
* fix * add simple test * fix imports * add changelog * tighter test with on_fit_start hook closer to the dispatch call * move class inside test f unction * add a comment (cherry picked from commit fc6d402)
This was referenced Mar 17, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6364
All this PR does is delay the first calls to the logger to a point where the worker processes (e.g. in DDP) have access to their rank information. This prevents the logger from writing to the same file in every process
The added test fails on master.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃