Fix for multiple callbacks #6197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
added
bug
SeanNaren
requested review from
carmocca,
justusschock,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6197 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 159 159
Lines 11378 11375 -3
======================================
- Hits 10623 10591 -32
- Misses 755 784 +29 |
kaushikb11
reviewed
Feb 25, 2021
Borda
requested changes
Feb 25, 2021
Borda
approved these changes
Feb 25, 2021
Borda
reviewed
Feb 25, 2021
Comment on lines
+362
to
+363
| def on_train_end(self) -> None: | ||
| assert self.trainer.current_epoch == self.expected_end_epoch, 'Early Stopping Failed' |
Collaborator
There was a problem hiding this comment.
I would drop this and rather check in the test trainer epoch is as expected, so there is not random inference
Contributor
Author
There was a problem hiding this comment.
That's what I originally did but because of how DDP Spawn works, the local trainer's current epoch doesn't seem to be kept in sync which is fair (since it's only kept in sync during trainer on the processes). This is why I had to move it to on_train_end because this happens within the spawn process!
Contributor
Author
There was a problem hiding this comment.
We could but I'd need to separate out the tests, I don't think its really worth it because it would be a lot of duplication
kaushikb11
approved these changes
Feb 25, 2021
Closed
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Mar 2, 2021
* Fix for multiple callbacks * Add CHANGELOG.md * Remove old params * Skip tests on windows using ddp * Change name of the variable to not clash with should stop, which is separate * Apply suggestions from code review * Fix params Co-authored-by: Jirka Borovec <[email protected]>
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
Mar 2, 2021
* Fix for multiple callbacks * Add CHANGELOG.md * Remove old params * Skip tests on windows using ddp * Change name of the variable to not clash with should stop, which is separate * Apply suggestions from code review * Fix params Co-authored-by: Jirka Borovec <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Mar 5, 2021
* Fix for multiple callbacks * Add CHANGELOG.md * Remove old params * Skip tests on windows using ddp * Change name of the variable to not clash with should stop, which is separate * Apply suggestions from code review * Fix params Co-authored-by: Jirka Borovec <[email protected]>
This was referenced Mar 12, 2021
Closed
Closed
[tune](deps): Bump pytorch-lightning from 1.0.3 to 1.2.3 in /python/requirements
sumanthratna/ray#12
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6194
We recently modified the behaviour of the early stopping callback in the accelerator refactor, this led to the bug mentioned above. This was due to defaulting to False, when other callbacks could've updated this value to True.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃