Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 21, 2021

What does this PR do?

Fixes #6097

Apex/amp and CPU are not compatible.
The MisconfigurationError was never raised and tests are flawed, because they would run on ddp_cpu yet never get to the point where an error is raised because of early SystemExit...

More tests for accelerators will be added in #6102

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Feb 21, 2021
@awaelchli awaelchli modified the milestones: 1.3, 1.2.x Feb 21, 2021
@awaelchli awaelchli added the ci Continuous Integration label Feb 21, 2021
@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #6107 (c4e7c45) into master (3b0e4e0) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #6107   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         160     160           
  Lines       11405   11405           
======================================
  Hits        10661   10661           
  Misses        744     744           

@awaelchli awaelchli changed the title fix apex misconfiguration for cpu fix amp/apex misconfiguration error for cpu Feb 21, 2021
@awaelchli awaelchli marked this pull request as ready for review February 21, 2021 15:11
@Borda Borda enabled auto-merge (squash) February 21, 2021 20:47
@Borda Borda merged commit ae6ce17 into master Feb 22, 2021
@Borda Borda deleted the tests/apex branch February 22, 2021 00:02
@carmocca carmocca mentioned this pull request Feb 22, 2021
carmocca pushed a commit that referenced this pull request Feb 23, 2021
* fix weird test

* fix apex plugin test

* fix raise

* cpu test

* fix type

* add changelog
lexierule pushed a commit that referenced this pull request Feb 24, 2021
* fix weird test

* fix apex plugin test

* fix raise

* cpu test

* fix type

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apex amp not working in 1.2.0

4 participants