-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix amp/apex misconfiguration error for cpu #6107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6107 +/- ##
======================================
Coverage 93% 93%
======================================
Files 160 160
Lines 11405 11405
======================================
Hits 10661 10661
Misses 744 744 |
SeanNaren
approved these changes
Feb 21, 2021
Borda
approved these changes
Feb 21, 2021
carmocca
approved these changes
Feb 22, 2021
Closed
carmocca
pushed a commit
that referenced
this pull request
Feb 23, 2021
* fix weird test * fix apex plugin test * fix raise * cpu test * fix type * add changelog
lexierule
pushed a commit
that referenced
this pull request
Feb 24, 2021
* fix weird test * fix apex plugin test * fix raise * cpu test * fix type * add changelog
This was referenced Mar 13, 2021
Closed
Closed
[tune](deps): Bump pytorch-lightning from 1.0.3 to 1.2.3 in /python/requirements
sumanthratna/ray#12
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6097
Apex/amp and CPU are not compatible.
The MisconfigurationError was never raised and tests are flawed, because they would run on ddp_cpu yet never get to the point where an error is raised because of early SystemExit...
More tests for accelerators will be added in #6102
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃