Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jan 18, 2021

What does this PR do?

The docs of BackboneLambdaFinetuningCallback and BaseFinetuningCallback aren't available right now, which was probably missed in #5377.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the docs Documentation related label Jan 18, 2021
@carmocca carmocca enabled auto-merge (squash) January 19, 2021 14:33
@carmocca carmocca added the ready PRs ready to be merged label Jan 19, 2021
@tchaton tchaton disabled auto-merge January 24, 2021 10:00
@tchaton
Copy link
Contributor

tchaton commented Jan 24, 2021

Hey @akihironitta @awaelchli @carmocca ,

After reflexion, I realise the Callback names aren't great !

Any proposition for better names ?

Best,
T.C

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #5553 (fd1a71f) into release/1.2-dev (db78422) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.2-dev   #5553   +/-   ##
===============================================
  Coverage               92%     92%           
===============================================
  Files                  153     153           
  Lines                10860   10860           
===============================================
  Hits                 10037   10037           
  Misses                 823     823           

@carmocca
Copy link
Contributor

FinetuneCallback or FinetuningCallback are the simplest

@SeanNaren SeanNaren merged commit 30f31d3 into Lightning-AI:release/1.2-dev Jan 25, 2021
@akihironitta akihironitta deleted the docs/add-BackboneLambdaFinetunningCallback branch January 26, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants