Skip to content

Conversation

@tchaton
Copy link
Contributor

@tchaton tchaton commented Jan 8, 2021

What does this PR do?

This PR is a checkout from #5185 and resolves manual_optimization and pipe tests.

Fixes # (issue) <- this links related issue to this PR

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jan 8, 2021

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-08 10:20:52 UTC

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #5415 (c839b0d) into release/1.2-dev (06668c0) will decrease coverage by 0%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5415   +/-   ##
===============================================
- Coverage               93%     93%   -0%     
===============================================
  Files                  148     148           
  Lines                10480   10475    -5     
===============================================
- Hits                  9709    9703    -6     
- Misses                 771     772    +1     

@tchaton tchaton closed this Jan 8, 2021
@tchaton tchaton deleted the refactor/distrib-wrapper_tc branch January 8, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants