Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jan 4, 2021

What does this PR do?

there were a few critical bigs - unimplemented methods...

Fixes #1959

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working priority: 0 High priority task labels Jan 4, 2021
@Borda Borda added this to the 1.2 milestone Jan 4, 2021
@Borda Borda requested a review from justusschock January 4, 2021 21:26
@Borda Borda marked this pull request as ready for review January 4, 2021 22:22
@Borda Borda requested review from a team, carmocca, lezwon, nateraw, s-rog, teddykoker and yukw777 January 4, 2021 22:40
@Borda Borda enabled auto-merge (squash) January 4, 2021 23:10
@rohitgr7 rohitgr7 mentioned this pull request Jan 5, 2021
12 tasks
@Borda Borda requested a review from rohitgr7 January 5, 2021 07:51
@Borda Borda merged commit c72880f into release/1.2-dev Jan 5, 2021
@Borda Borda deleted the bugfix/dataloaders branch January 5, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: 0 High priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants