test_cpu and test_gpu EvalModelTemplate deprecation #4820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianscarpe
requested review from
Borda,
SeanNaren,
ananyahjha93,
awaelchli,
justusschock,
nateraw,
tchaton,
teddykoker and
williamFalcon
as code owners
gianscarpe
force-pushed
the
issue3827_test_gpu_and_cpu
branch
from
d5b9706 to
938f252
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #4820 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 146 146
Lines 10361 10361
===============================================
Hits 9597 9597
Misses 764 764 |
Contributor
Author
|
First PR for refactoring tests and deprecating EvalModelTemplater is ready for review! 💯 @SeanNaren |
Borda
requested changes
Nov 24, 2020
Contributor
|
@gianscarpe it's not required to update the branch every time it gets out-of-date with the base :] |
rohitgr7
reviewed
Nov 24, 2020
|
Hello @gianscarpe! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-07 09:39:58 UTC |
rohitgr7
reviewed
Nov 25, 2020
Contributor
Author
rohitgr7
reviewed
Nov 30, 2020
Contributor
rohitgr7
left a comment
rohitgr7
left a comment
There was a problem hiding this comment.
Just some more suggestions. Else LGTM.
Contributor
Author
|
@Borda Hi, I merged master branch and solved the issues :) |
Contributor
Author
|
@rohitgr7 Thank you for the effort in reviewing my PR! I really appreciated it :) |
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
* Add colab badges to notebook Add colab badges to notebook to notebooks 4 & 5 * Add colab badges Co-authored-by: chaton <[email protected]>
This reverts commit 5c0b31c.
This reverts commit 89a25795b5082dbb672709449554f9180b96fdfe.
gianscarpe
force-pushed
the
issue3827_test_gpu_and_cpu
branch
from
b728f86 to
6423611
Compare
Borda
requested changes
Jan 5, 2021
Borda
approved these changes
Jan 5, 2021
Collaborator
|
@tchaton mind re-review? ^^ |
tchaton
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR deprecates EvalModelTemplate and old pl APIs in favor of BoringModel in
tests/models/test_cpuandtests/models/test_gpu. BoringModel is inherited in fortest_tbpttintest_cpu. A dispatcher function guaranteesEvalModelTemplatebackward compatibility while completing the deprecationFixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Absolutely!