Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Nov 17, 2020

What does this PR do?

Fixes #4655

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks

This comment has been minimized.

@rohitgr7
Copy link
Contributor Author

The only problem left here is with ReduceLROnPlateau. This scheduler needs a monitor to update. If it's done on epoch level then it won't get the monitored key/value since checkpoints are created before epoch metrics are aggregated. Does anyone got a suggestion??

@Borda Borda added bug Something isn't working help wanted Open to be worked on tuner labels Nov 30, 2020
@Borda Borda added this to the 1.1.x milestone Nov 30, 2020
@rohitgr7
Copy link
Contributor Author

fixing it here: #5208

@rohitgr7 rohitgr7 closed this Dec 27, 2020
@rohitgr7 rohitgr7 deleted the bugfix/lr_sched_epoch branch December 27, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working help wanted Open to be worked on tuner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LR scheduler lags behind after resume_from_checkpoint

3 participants