-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Enable DDP Plugin to pass through args to LightningDistributedDataParallel #4382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4382 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8135 8099 -36
======================================
- Hits 7526 7509 -17
+ Misses 609 590 -19 |
awaelchli
approved these changes
Oct 27, 2020
ananthsub
commented
Oct 27, 2020
justusschock
approved these changes
Oct 27, 2020
tchaton
approved these changes
Oct 27, 2020
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome addition !
SkafteNicki
reviewed
Oct 27, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes the DDP Plugin more generic, so people don't have to subclass if they only want to change what goes into the
DistributedDataParallelconstructor. This preservesfind_unused_parameters=Trueas the default.Related: is
find_unused_parametersforced to be True since Lightning wraps the whole LightningModule inLightningDistributedDataParallel?cc @williamFalcon
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃