-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Metrics] Fix/4237 auc unstable reorder #4281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] Fix/4237 auc unstable reorder #4281
Conversation
SkafteNicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #4281 +/- ##
=======================================
+ Coverage 92% 93% +1%
=======================================
Files 111 111
Lines 8123 8011 -112
=======================================
- Hits 7482 7448 -34
+ Misses 641 563 -78 |
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch ! I didn't know argsort was unstable.
|
@ddrevicky could you please solve the pep8 issue: |
|
This pull request is now in conflict... :( |
0820cde to
a571b78
Compare
0894eae to
ef04bd4
Compare
What does this PR do?
Deprecates the
reorderparameter to theaucmetric because oftorch.argsortbeing unstable.Fixes #4237
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃