-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix on_train_batch_start hook to end epoch early
#3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix on_train_batch_start hook to end epoch early
#3700
Conversation
on_train_batch_start to end epochon_train_batch_start to end epoch early
on_train_batch_start to end epoch earlyon_train_batch_start hook to end epoch early
|
It's ready to review. |
Co-authored-by: Jirka Borovec <[email protected]>
Borda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #3700 +/- ##
========================================
- Coverage 85% 79% -6%
========================================
Files 110 112 +2
Lines 8387 10236 +1849
========================================
+ Hits 7170 8114 +944
- Misses 1217 2122 +905 |
SkafteNicki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
rohitgr7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
What does this PR do?
Fixes #3693
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃