Skip to content

ci: update signaling #15981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 9, 2022
Merged

ci: update signaling #15981

merged 4 commits into from
Dec 9, 2022

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Dec 9, 2022 •
edited by github-actions bot
Loading

What does this PR do?

contra-part for https://github.com/gridai/base-images/pull/66

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @akihironitta

@Borda
Copy link
Collaborator Author

Borda commented Dec 9, 2022

checking the pass:
image

@Borda Borda marked this pull request as ready for review December 9, 2022 09:56
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested review from a team, narJH27 and nicolai86 December 9, 2022 09:57
@Borda Borda added the release label Dec 9, 2022
@Borda Borda enabled auto-merge (squash) December 9, 2022 09:57
akihironitta
akihironitta approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot added the ready PRs ready to be merged label Dec 9, 2022
@Borda Borda merged commit e56e7f1 into master Dec 9, 2022
@Borda Borda deleted the ci/release branch December 9, 2022 12:19
@akihironitta akihironitta added the ci Continuous Integration label Dec 9, 2022
Borda added a commit that referenced this pull request Dec 9, 2022
@Borda
ci: update signaling (#15981)
843786f 
* ci: update signaling
* config

(cherry picked from commit e56e7f1)
lantiga added a commit that referenced this pull request Dec 9, 2022
@Borda @lantiga
@tchaton @akihironitta @Liyang90 @justusschock @ethanwharris
Releasing/1.8.4.post (#15988)
6a39743 
* Apply dynamo to training_step, validation_step, test_step, predict_step (#15957)

* Apply dynamo to training_step, validation_step, test_step, predict_step

* Add entry to CHANGELOG.md

(cherry picked from commit edc9986)

* [App] Resolve run installation (#15974)

(cherry picked from commit dd83587)

* App: Move AutoScaler dependency to extra requirements (#15971)

* Make autoscaler dependency optional
* update chglog
* dont directly import aiohttp

(cherry picked from commit 346e936)

# Conflicts:
#	requirements/app/base.txt
#	src/lightning_app/CHANGELOG.md

* Avoid using the same port number for autoscaler works (#15966)

* dont hardcode port in python server
* add another chglog

(cherry picked from commit a72d268)

* Fix `action_name` usage in `XLAProfiler` (#15886)

* Fix `action_name` usage in `XLAProfiler`
* add changelog
* Update src/pytorch_ligh
* Update xla.py

Co-authored-by: awaelchli <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit c748f82)

* Fix multinode cloud component (#15965)

* fix multinode cloud component
* add tests

(cherry picked from commit d21b899)

* ci: update signaling (#15981)

* ci: update signaling
* config

(cherry picked from commit e56e7f1)

* Fix cloudcomputes registration for structures (#15964)

* fix cloudcomputes
* updates cloudcompute registration
* changelog

(cherry picked from commit 90a4c02)

* Document running dev lightning on the cloud (#15962)

* document running dev lightning on the cloud

* document running dev lightning on the cloud

* Update .github/CONTRIBUTING.md

Co-authored-by: Noha Alon <[email protected]>

* document running dev lightning on the cloud

* git clone & pip install -e

* Update .github/CONTRIBUTING.md

Co-authored-by: Jirka Borovec <[email protected]>

Co-authored-by: Noha Alon <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
(cherry picked from commit cfd00d3)

* [App] Install exact version whn upgrading and not when testing (#15984)

* [App] Install exact version whn upgrading and not when testing
* Update CHANGELOG.md

Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit 1657ea8)

* releasing 1.8.4.post0

Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Liyang90 <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Ethan Harris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carmocca carmocca Awaiting requested review from carmocca

@narJH27 narJH27 Awaiting requested review from narJH27

@nicolai86 nicolai86 Awaiting requested review from nicolai86

2 more reviewers

@akihironitta akihironitta akihironitta approved these changes

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci Continuous Integration ready PRs ready to be merged release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Borda @awaelchli @akihironitta