-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Support fused Adam with mixed precision #15555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusschock
approved these changes
Nov 8, 2022
carmocca
approved these changes
Nov 8, 2022
12 tasks
Borda
pushed a commit
that referenced
this pull request
Nov 8, 2022
Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit e4611ef)
lexierule
pushed a commit
that referenced
this pull request
Nov 10, 2022
Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit e4611ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
fun
Staff contributions outside working hours - to differentiate from the "community" label
optimization
pl
Generic label for PyTorch Lightning package
precision: amp
Automatic Mixed Precision
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #15501
PyTorch 1.13 introduced
Adam(fused=True|False). It fuses several operations in the step() method of the optimizer to speed up execution (reduced number of kernel launches). However, since certain operations get fused together, we can no longer unscale the gradients independently in case we want to do gradient clipping. With a fused optimizer like Adam, the unscaling gets handled directly in the step method. Furthermore, a call toscaler.unscale_(optimizer)in our precision plugin currently leads to gradients being unscaled twice in the case of fused Adam, which is undesired. We address both issues in this PR.A more detailed explanation is here.
In summary:
Follow up work:
Does your PR introduce any breaking changes? If yes, please list them.
None intended.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @carmocca @justusschock @awaelchli @akihironitta