From 0f6c047b2805d3b2352020dece841cc1ff565ad2 Mon Sep 17 00:00:00 2001 From: Masahiro Wada Date: Thu, 29 Sep 2022 11:59:27 +0000 Subject: [PATCH 1/2] Move type annotation into __init__ --- src/pytorch_lightning/callbacks/batch_size_finder.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/pytorch_lightning/callbacks/batch_size_finder.py b/src/pytorch_lightning/callbacks/batch_size_finder.py index 96b9f6eef874e..ea822986cfdae 100644 --- a/src/pytorch_lightning/callbacks/batch_size_finder.py +++ b/src/pytorch_lightning/callbacks/batch_size_finder.py @@ -31,8 +31,6 @@ class BatchSizeFinder(Callback): SUPPORTED_MODES = ("power", "binsearch") - optimal_batch_size: Optional[int] - def __init__( self, mode: str = "power", @@ -73,7 +71,7 @@ def __init__( mode = mode.lower() if mode not in self.SUPPORTED_MODES: raise ValueError(f"`mode` should be either of {self.SUPPORTED_MODES}") - self.optimal_batch_size = init_val + self.optimal_batch_size: Optional[int] = init_val self._mode = mode self._steps_per_trial = steps_per_trial self._init_val = init_val From 9b7f190ba86f26ff7a7778b6547d9a83c70aeb9c Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 29 Sep 2022 13:12:14 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/pytorch_lightning/callbacks/batch_size_finder.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pytorch_lightning/callbacks/batch_size_finder.py b/src/pytorch_lightning/callbacks/batch_size_finder.py index ea822986cfdae..0d70f43b8ad35 100644 --- a/src/pytorch_lightning/callbacks/batch_size_finder.py +++ b/src/pytorch_lightning/callbacks/batch_size_finder.py @@ -71,7 +71,7 @@ def __init__( mode = mode.lower() if mode not in self.SUPPORTED_MODES: raise ValueError(f"`mode` should be either of {self.SUPPORTED_MODES}") - self.optimal_batch_size: Optional[int] = init_val + self.optimal_batch_size: Optional[int] = init_val self._mode = mode self._steps_per_trial = steps_per_trial self._init_val = init_val