Skip to content

Conversation

@manskx
Copy link
Contributor

@manskx manskx commented Aug 26, 2022

What does this PR do?

Fixing this error in running CI tests

ImportError while loading conftest '/home/runner/work/lightning/lightning/tests/tests_app/conftest.py'.
tests_app/conftest.py:7: in <module>
    import psutil
E   ModuleNotFoundError: No module named 'psutil'

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 26, 2022
@manskx manskx added the ci Continuous Integration label Aug 26, 2022
@manskx manskx added this to the all:next milestone Aug 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2022
@manskx manskx enabled auto-merge (squash) August 26, 2022 23:26
@manskx manskx merged commit 0e30e4a into master Aug 26, 2022
@manskx manskx deleted the manskx/app/ci/fix-psutil-requirement branch August 26, 2022 23:55
@rohitgr7 rohitgr7 modified the milestones: all:next, app:0.6.x Aug 27, 2022
@rohitgr7
Copy link
Contributor

rohitgr7 commented Aug 27, 2022

qq: why was it marked as all:next? since it only touches the app.

@Borda Borda modified the milestones: all:next, app:0.6.x Aug 29, 2022
@Borda
Copy link
Collaborator

Borda commented Aug 29, 2022

qq: why was it marked as all:next? since it only touches the app.

fixed, shall go to App :)

@Borda Borda modified the milestones: app:0.6.x, app:0.6 Aug 29, 2022
krshrimali pushed a commit that referenced this pull request Sep 6, 2022
lexierule pushed a commit that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants