From 37cea4ff12bc5246dbc426e585d67cda41c7a0c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 14:37:06 +0200 Subject: [PATCH 01/18] Push template --- .github/checkgroup.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/checkgroup.yml diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml new file mode 100644 index 0000000000000..a5d2567532f66 --- /dev/null +++ b/.github/checkgroup.yml @@ -0,0 +1,20 @@ +subprojects: + - id: documentation + paths: + - "docs/**.md" + checks: + - "markdown_lint" + - "github_pages_build" + - id: mobile_app + paths: + - "clients/app/**" + checks: + - "app_static_analysis" + - "app_unit_tests" + - "compatibility_check" + - id: cli_app + paths: + - "clients/cli/**" + checks: + - "cli_unit_tests" + - "compatibility_check" From da50417863b5082198f66b55469bae626b7887b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 14:53:32 +0200 Subject: [PATCH 02/18] pytorch_lightning paths --- .github/checkgroup.yml | 39 ++++++++++++++++++++++++++------------- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index a5d2567532f66..0d19a4da3fa69 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -1,20 +1,33 @@ subprojects: - - id: documentation + - id: pytorch_lightning paths: - - "docs/**.md" + - ".circleci/**" + - ".azure/**" + - "docs/source-pytorch/**" + # examples don't need to be added because they aren't used in CI, but these are + - "examples/test_pl_examples.py" + - "examples/run_ddp_examples.sh" + - "examples/run_pl_examples.sh" + - "requirements/pytorch/**" + - "src/pytorch_lightning/**" + - "setup.cfg" # includes pytest config + - "pyproject.toml" # includes mypy config checks: - - "markdown_lint" - - "github_pages_build" - - id: mobile_app + - "TODO" + - id: pytorch_lightning dockers paths: - - "clients/app/**" + - "dockers/**" checks: - - "app_static_analysis" - - "app_unit_tests" - - "compatibility_check" - - id: cli_app + - "TODO" + - id: lightning_app paths: - - "clients/cli/**" + - "TODO" checks: - - "cli_unit_tests" - - "compatibility_check" + - "TODO" + - id: general + paths: + - ".github/**" + - ".pre-commit-config.yaml" + - "setup.py" + checks: + - "TODO" From 3ed0c278e21dc277519724300d374f071c1200e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 16:30:08 +0200 Subject: [PATCH 03/18] Adding checks --- .github/checkgroup.yml | 62 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 59 insertions(+), 3 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 0d19a4da3fa69..b15b844a15feb 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -13,21 +13,77 @@ subprojects: - "setup.cfg" # includes pytest config - "pyproject.toml" # includes mypy config checks: - - "TODO" + - "check / schema" + - "conda (3.8, 1.10)" + - "conda (3.8, 1.9)" + - "conda (3.9, 1.11)" + - "conda (3.9, 1.12)" + - "cpu (macOS-11, 3.10, latest, stable)" + - "cpu (macOS-11, 3.7, latest, stable)" + - "cpu (macOS-11, 3.7, oldest, stable)" + - "cpu (ubuntu-20.04, 3.10, latest, stable)" + - "cpu (ubuntu-20.04, 3.7, latest, stable)" + - "cpu (ubuntu-20.04, 3.7, oldest, stable)" + - "cpu (windows-2022, 3.10, latest, stable)" + - "cpu (windows-2022, 3.7, latest, stable)" + - "cpu (windows-2022, 3.7, oldest, stable)" + - "doctest (pytorch)" + - "make-docs (pytorch)" + - "mypy" + - "PR Gatekeeper (pytorch)" + - "pytest (macOS-11, 3.8, latest)" + - "pytest (macOS-11, 3.8, oldest)" + - "pytest (ubuntu-20.04, 3.8, latest)" + - "pytest (ubuntu-20.04, 3.8, oldest)" + - "pytest (windows-2022, 3.8, latest)" + - "pytest (windows-2022, 3.8, oldest)" + - "pytorch-lightning (GPUs)" + - "pytorch-lightning (GPUs) (testing PyTorch - stable)" + - "pytorch-lightning (HPUs)" + - "pytorch-lightning (IPUs)" + - "slow (macOS-11, 3.7, 1.11)" + - "slow (ubuntu-20.04, 3.7, 1.11)" + - "slow (windows-2022, 3.7, 1.11)" + - "test-on-tpus" + - id: pytorch_lightning dockers paths: - "dockers/**" checks: - "TODO" + - id: lightning_app paths: - "TODO" checks: - "TODO" - - id: general + + - id: ci paths: + - ".actions/setup_tools.py" + - "assistant.py" - ".github/**" - ".pre-commit-config.yaml" - "setup.py" checks: - - "TODO" + - "install-meta-pypi (macOS-11, 3.8)" + - "install-meta-pypi (ubuntu-20.04, 3.8)" + - "install-meta-pypi (windows-2022, 3.8)" + - "install-meta-src (macOS-11, 3.8)" + - "install-meta-src (macOS-11, lightning, 3.8)" + - "install-meta-src (ubuntu-20.04, 3.8)" + - "install-meta-src (ubuntu-20.04, lightning, 3.8)" + - "install-meta-src (windows-2022, 3.8)" + - "install-meta-src (windows-2022, lightning, 3.8)" + - "install-standalone (macOS-11, app, 3.8)" + - "install-standalone (macOS-11, pytorch, 3.8)" + - "install-standalone (ubuntu-20.04, app, 3.8)" + - "install-standalone (ubuntu-20.04, pytorch, 3.8)" + - "install-standalone (windows-2022, app, 3.8)" + - "install-standalone (windows-2022, pytorch, 3.8)" + + - id: all + paths: + - "**" + checks: + - "WIP" From 065e24f989a8fc5faa2dd94a04a572e2e358d6fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 16:32:32 +0200 Subject: [PATCH 04/18] Dockers --- .github/checkgroup.yml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index b15b844a15feb..8e783eddac791 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -50,7 +50,23 @@ subprojects: paths: - "dockers/**" checks: - - "TODO" + - "build-conda (3.8, 1.10)" + - "build-conda (3.8, 1.9)" + - "build-conda (3.9, 1.11)" + - "build-conda (3.9, 1.12)" + - "build-cuda (3.8, 1.9, 11.1.1)" + - "build-cuda (3.9, 1.10, 11.3.1)" + - "build-cuda (3.9, 1.11, 11.3.1)" + - "build-cuda (3.9, 1.12, 11.3.1)" + - "build-cuda (3.9, 1.9, 11.1.1)" + - "build-hpu (1.5.0, 1.11.0)" + - "build-ipu (3.9, 1.9)" + - "build-NGC" + - "build-pl (3.9, 1.10, 11.3.1)" + - "build-pl (3.9, 1.11, 11.3.1)" + - "build-pl (3.9, 1.12, 11.3.1)" + - "build-pl (3.9, 1.9, 11.1.1)" + - "build-xla (3.7, 1.12)" - id: lightning_app paths: From 8d165a03f5f1fe7d0d06eb7ab170942ea776335f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 16:37:28 +0200 Subject: [PATCH 05/18] Minor change --- .github/checkgroup.yml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 8e783eddac791..fd356f3965b68 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -1,5 +1,6 @@ +custom_service_name: "Lightning CI required checker" subprojects: - - id: pytorch_lightning + - id: "pytorch_lightning" paths: - ".circleci/**" - ".azure/**" @@ -46,7 +47,7 @@ subprojects: - "slow (windows-2022, 3.7, 1.11)" - "test-on-tpus" - - id: pytorch_lightning dockers + - id: "pytorch_lightning dockers" paths: - "dockers/**" checks: @@ -74,12 +75,11 @@ subprojects: checks: - "TODO" - - id: ci + - id: "ci" paths: - ".actions/setup_tools.py" - "assistant.py" - ".github/**" - - ".pre-commit-config.yaml" - "setup.py" checks: - "install-meta-pypi (macOS-11, 3.8)" @@ -97,9 +97,3 @@ subprojects: - "install-standalone (ubuntu-20.04, pytorch, 3.8)" - "install-standalone (windows-2022, app, 3.8)" - "install-standalone (windows-2022, pytorch, 3.8)" - - - id: all - paths: - - "**" - checks: - - "WIP" From 9a457f55b8d5458ca6baab8bf70611976791cd10 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 17:06:13 +0200 Subject: [PATCH 06/18] Finish checkgroup --- .github/checkgroup.yml | 43 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index fd356f3965b68..57ae40fc9d6e4 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -11,8 +11,14 @@ subprojects: - "examples/run_pl_examples.sh" - "requirements/pytorch/**" - "src/pytorch_lightning/**" + - "tests/tests_pytorch/**" - "setup.cfg" # includes pytest config - "pyproject.toml" # includes mypy config + - ".readthedocs.yml" + - ".github/workflows/_check-schema.yml" + - ".github/workflows/ci-schema.yml" + - ".github/workflows/ci-pytorch*.yml" + - ".github/workflows/docs-*.yml" checks: - "check / schema" - "conda (3.8, 1.10)" @@ -69,18 +75,47 @@ subprojects: - "build-pl (3.9, 1.9, 11.1.1)" - "build-xla (3.7, 1.12)" - - id: lightning_app + - id: "pytorch_lightning mypy" paths: - - "TODO" + - ".github/workflows/code-checks.yml" checks: - - "TODO" + - "mypy" + + - id: "lightning_app" + paths: + - ".github/workflows/ci-app*.yml" + - ".github/workflows/docs-*.yml" + - "docs/source-app/**" + - "examples/app_**" + - "requirements/app/**" + - "src/lightning_app/**" + - "tests/tests_app/**" + - "tests/tests_app_examples/**" + - "tests/tests_clusters/**" + # the examples are used in the app CI + - "examples/app_*" + checks: + - "Cloud Test (boring_app)" + - "Cloud Test (collect_failures)" + - "Cloud Test (commands_and_api)" + - "Cloud Test (custom_work_dependencies)" + - "Cloud Test (drive)" + - "Cloud Test (idle_timeout)" + - "Cloud Test (payload)" + - "Cloud Test (template_jupyterlab)" + - "Cloud Test (template_react_ui)" + - "Cloud Test (template_streamlit_ui)" + - "Cloud Test (v0_app)" + - "doctest (app)" + - "make-docs (app)" - id: "ci" paths: - ".actions/setup_tools.py" - "assistant.py" - - ".github/**" + - ".github/workflows/ci-pkg-install.yml" - "setup.py" + - "src/lightning/**" checks: - "install-meta-pypi (macOS-11, 3.8)" - "install-meta-pypi (ubuntu-20.04, 3.8)" From 277b56682672db623ea08aac33f846f13592aa73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 17:17:08 +0200 Subject: [PATCH 07/18] Missed some examples --- .github/checkgroup.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 57ae40fc9d6e4..1684e6f0c191b 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -5,10 +5,16 @@ subprojects: - ".circleci/**" - ".azure/**" - "docs/source-pytorch/**" - # examples don't need to be added because they aren't used in CI, but these are - - "examples/test_pl_examples.py" + # all examples don't need to be added because they aren't used in CI, but these are - "examples/run_ddp_examples.sh" + - "examples/convert_from_pt_to_pl/**" - "examples/run_pl_examples.sh" + - "examples/pl_basics/backbone_image_classifier.py" + - "examples/pl_basics/autoencoder.py" + - "examples/pl_loops/mnist_lite.py" + - "examples/pl_fault_tolerant/automatic.py" + - "examples/test_pl_examples.py" + - "examples/pl_integrations/dali_image_classifier.py" - "requirements/pytorch/**" - "src/pytorch_lightning/**" - "tests/tests_pytorch/**" From 23ed7e69e0b6c66d756001575faa379cb47a310c Mon Sep 17 00:00:00 2001 From: Jirka Date: Thu, 11 Aug 2022 17:23:34 +0200 Subject: [PATCH 08/18] PL docs --- .github/checkgroup.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 1684e6f0c191b..9f39a6192a572 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -4,7 +4,6 @@ subprojects: paths: - ".circleci/**" - ".azure/**" - - "docs/source-pytorch/**" # all examples don't need to be added because they aren't used in CI, but these are - "examples/run_ddp_examples.sh" - "examples/convert_from_pt_to_pl/**" @@ -59,6 +58,14 @@ subprojects: - "slow (windows-2022, 3.7, 1.11)" - "test-on-tpus" + - id: "pytorch_lightning: Docs" + paths: + - "docs/source-pytorch/**" + - ".github/workflows/docs-*.yml" + checks: + - "doctest (pytorch)" + - "make-docs (pytorch)" + - id: "pytorch_lightning dockers" paths: - "dockers/**" From 310bd62ec572c425ce7203ba8a0d7ce6c93a8211 Mon Sep 17 00:00:00 2001 From: Jirka Date: Thu, 11 Aug 2022 17:25:04 +0200 Subject: [PATCH 09/18] App docs --- .github/checkgroup.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 9f39a6192a572..9f2eb473364aa 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -98,7 +98,6 @@ subprojects: paths: - ".github/workflows/ci-app*.yml" - ".github/workflows/docs-*.yml" - - "docs/source-app/**" - "examples/app_**" - "requirements/app/**" - "src/lightning_app/**" @@ -122,6 +121,14 @@ subprojects: - "doctest (app)" - "make-docs (app)" + - id: "lightning_app: Docs" + paths: + - "docs/source-app/**" + - ".github/workflows/docs-*.yml" + checks: + - "doctest (app)" + - "make-docs (app)" + - id: "ci" paths: - ".actions/setup_tools.py" From 7c9b82e1cc953e94ef6afffe6bbfc3ecbadbc0dd Mon Sep 17 00:00:00 2001 From: Jirka Date: Thu, 11 Aug 2022 17:27:08 +0200 Subject: [PATCH 10/18] CI --- .github/checkgroup.yml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 9f2eb473364aa..40230a87363c0 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -1,9 +1,22 @@ custom_service_name: "Lightning CI required checker" subprojects: - - id: "pytorch_lightning" + - id: "CI: CircleCI" paths: - ".circleci/**" + checks: + - "test-on-tpus" + + - id: "CI: Azure" + paths: - ".azure/**" + checks: + - "pytorch-lightning (GPUs)" + - "pytorch-lightning (GPUs) (testing PyTorch - stable)" + - "pytorch-lightning (HPUs)" + - "pytorch-lightning (IPUs)" + + - id: "pytorch_lightning" + paths: # all examples don't need to be added because they aren't used in CI, but these are - "examples/run_ddp_examples.sh" - "examples/convert_from_pt_to_pl/**" From a169efa3a18fd28dc7f394bd1aeba23afb6d9b29 Mon Sep 17 00:00:00 2001 From: Jirka Date: Thu, 11 Aug 2022 17:29:05 +0200 Subject: [PATCH 11/18] fix docs + require --- .github/checkgroup.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 40230a87363c0..052075aa20fb3 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -75,6 +75,7 @@ subprojects: paths: - "docs/source-pytorch/**" - ".github/workflows/docs-*.yml" + - "requirements/pytorch/**" checks: - "doctest (pytorch)" - "make-docs (pytorch)" @@ -138,6 +139,7 @@ subprojects: paths: - "docs/source-app/**" - ".github/workflows/docs-*.yml" + - "requirements/app/**" checks: - "doctest (app)" - "make-docs (app)" From 463b65d9c3b336843153171531713500970e8887 Mon Sep 17 00:00:00 2001 From: Jirka Date: Thu, 11 Aug 2022 17:31:29 +0200 Subject: [PATCH 12/18] fix install --- .github/checkgroup.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 052075aa20fb3..4a2d9e3cb8e05 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -144,13 +144,14 @@ subprojects: - "doctest (app)" - "make-docs (app)" - - id: "ci" + - id: "install" paths: - ".actions/setup_tools.py" - - "assistant.py" - ".github/workflows/ci-pkg-install.yml" - "setup.py" - "src/lightning/**" + # all __about__, __version__, __setup__ + - "src/*/__*.py" checks: - "install-meta-pypi (macOS-11, 3.8)" - "install-meta-pypi (ubuntu-20.04, 3.8)" From ccb6590da636e1dd9151ea62fb3c450f980c189f Mon Sep 17 00:00:00 2001 From: Jirka Date: Thu, 11 Aug 2022 17:32:41 +0200 Subject: [PATCH 13/18] always schema --- .github/checkgroup.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 4a2d9e3cb8e05..40139c97119aa 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -33,12 +33,9 @@ subprojects: - "setup.cfg" # includes pytest config - "pyproject.toml" # includes mypy config - ".readthedocs.yml" - - ".github/workflows/_check-schema.yml" - - ".github/workflows/ci-schema.yml" - ".github/workflows/ci-pytorch*.yml" - ".github/workflows/docs-*.yml" checks: - - "check / schema" - "conda (3.8, 1.10)" - "conda (3.8, 1.9)" - "conda (3.9, 1.11)" From edd165bca0e74804d3f4453fa470d9cbf0741c1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 17:32:34 +0200 Subject: [PATCH 14/18] Move app pytest tests to their group --- .github/checkgroup.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 40139c97119aa..2889e4555de23 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -53,12 +53,6 @@ subprojects: - "make-docs (pytorch)" - "mypy" - "PR Gatekeeper (pytorch)" - - "pytest (macOS-11, 3.8, latest)" - - "pytest (macOS-11, 3.8, oldest)" - - "pytest (ubuntu-20.04, 3.8, latest)" - - "pytest (ubuntu-20.04, 3.8, oldest)" - - "pytest (windows-2022, 3.8, latest)" - - "pytest (windows-2022, 3.8, oldest)" - "pytorch-lightning (GPUs)" - "pytorch-lightning (GPUs) (testing PyTorch - stable)" - "pytorch-lightning (HPUs)" @@ -131,6 +125,12 @@ subprojects: - "Cloud Test (v0_app)" - "doctest (app)" - "make-docs (app)" + - "pytest (macOS-11, 3.8, latest)" + - "pytest (macOS-11, 3.8, oldest)" + - "pytest (ubuntu-20.04, 3.8, latest)" + - "pytest (ubuntu-20.04, 3.8, oldest)" + - "pytest (windows-2022, 3.8, latest)" + - "pytest (windows-2022, 3.8, oldest)" - id: "lightning_app: Docs" paths: From 2abf51af667953635c5bc668b00580dc56dc9e29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 17:42:08 +0200 Subject: [PATCH 15/18] Name consistency --- .github/checkgroup.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 2889e4555de23..1d0d44da4a93b 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -71,7 +71,7 @@ subprojects: - "doctest (pytorch)" - "make-docs (pytorch)" - - id: "pytorch_lightning dockers" + - id: "pytorch_lightning: Docker" paths: - "dockers/**" checks: @@ -93,7 +93,7 @@ subprojects: - "build-pl (3.9, 1.9, 11.1.1)" - "build-xla (3.7, 1.12)" - - id: "pytorch_lightning mypy" + - id: "pytorch_lightning: mypy" paths: - ".github/workflows/code-checks.yml" checks: From 1d3ea3ef592929b51021d41f39db86185e1428ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 17:50:45 +0200 Subject: [PATCH 16/18] Apply suggestions from code review Co-authored-by: Jirka Borovec --- .github/checkgroup.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 1d0d44da4a93b..3b29ccd19ce21 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -31,7 +31,6 @@ subprojects: - "src/pytorch_lightning/**" - "tests/tests_pytorch/**" - "setup.cfg" # includes pytest config - - "pyproject.toml" # includes mypy config - ".readthedocs.yml" - ".github/workflows/ci-pytorch*.yml" - ".github/workflows/docs-*.yml" @@ -96,6 +95,7 @@ subprojects: - id: "pytorch_lightning: mypy" paths: - ".github/workflows/code-checks.yml" + - "pyproject.toml" # includes mypy config checks: - "mypy" From 8cab0f0e08f5864e4e08b9d2df0ed4498460326a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 17:51:13 +0200 Subject: [PATCH 17/18] Update .github/checkgroup.yml Co-authored-by: Jirka Borovec --- .github/checkgroup.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index 3b29ccd19ce21..b0dc911757a5e 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -102,7 +102,6 @@ subprojects: - id: "lightning_app" paths: - ".github/workflows/ci-app*.yml" - - ".github/workflows/docs-*.yml" - "examples/app_**" - "requirements/app/**" - "src/lightning_app/**" From 7e8a153b3ed34764823359adbd0937411c3e5707 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mochol=C3=AD?= Date: Thu, 11 Aug 2022 17:52:38 +0200 Subject: [PATCH 18/18] Update .github/checkgroup.yml Co-authored-by: Jirka Borovec --- .github/checkgroup.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/checkgroup.yml b/.github/checkgroup.yml index b0dc911757a5e..8f1d3c6fb5e86 100644 --- a/.github/checkgroup.yml +++ b/.github/checkgroup.yml @@ -31,7 +31,6 @@ subprojects: - "src/pytorch_lightning/**" - "tests/tests_pytorch/**" - "setup.cfg" # includes pytest config - - ".readthedocs.yml" - ".github/workflows/ci-pytorch*.yml" - ".github/workflows/docs-*.yml" checks: