Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Aug 6, 2022

What does this PR do?

  • Resolves timeout in master due to very slow dependency resolution by conda. (from >100min to <10min)
  • Most of the change comes from the base-cuda dockerfile.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@akihironitta akihironitta added ci Continuous Integration accelerator: ipu (removed) Intelligence Processing Unit labels Aug 6, 2022
@akihironitta akihironitta added this to the pl:1.8 milestone Aug 6, 2022
@akihironitta akihironitta changed the title [wip] CI: Update base-ipu docker image CI: Update base-ipu docker image Aug 6, 2022
@akihironitta akihironitta requested a review from kaushikb11 August 7, 2022 01:10
@mergify mergify bot added the ready PRs ready to be merged label Aug 8, 2022
@akihironitta akihironitta marked this pull request as draft August 15, 2022 10:43
@akihironitta
Copy link
Contributor Author

I'll keep this PR as draft so that we don't merge it before verifying it in the IPU CI.

@akihironitta akihironitta self-assigned this Aug 15, 2022
@akihironitta
Copy link
Contributor Author

akihironitta commented Sep 9, 2022

I'll keep this PR as draft so that we don't merge it before verifying it in the IPU CI.

This PR is basically ready, but I'd like to check in advance if the docker image built from this dockerfile works in our CI...

Could anyone help with merging this PR?

@akihironitta akihironitta marked this pull request as ready for review September 9, 2022 03:05
@otaj
Copy link
Contributor

otaj commented Sep 15, 2022

Hi, @akihironitta, what do you need help with? I'm here 🙂

@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 29, 2022
@akihironitta
Copy link
Contributor Author

For the note, the only task left here is to validate the change in the IPU server:

  • Replace the agent runner with the new docker image in the IPU CI server.

@akihironitta akihironitta changed the title CI: Update base-ipu docker image [wip] CI: Update base-ipu docker image Sep 29, 2022
@akihironitta akihironitta changed the title [wip] CI: Update base-ipu docker image [blocked] CI: Update base-ipu docker image Sep 30, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 30, 2022
@Borda Borda marked this pull request as draft October 5, 2022 09:55
@Borda
Copy link
Collaborator

Borda commented Oct 5, 2022

@akihironitta blocked in title does not do anything :)
so what needs to be done, publish the newly built image?

@carmocca carmocca removed the ready PRs ready to be merged label Oct 10, 2022
@carmocca carmocca removed this from the v1.8 milestone Oct 13, 2022
@justusschock
Copy link
Member

@akihironitta is this still relevant? Otherwise feel free to close it :)

@akihironitta akihironitta changed the title [blocked] CI: Update base-ipu docker image CI: Update base-ipu docker image Nov 9, 2022
@akihironitta
Copy link
Contributor Author

Closing this PR since #14934 fixed the original issue which this PR was trying to resolve.

@akihironitta akihironitta deleted the ci/fix-ipu-docker branch November 9, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: ipu (removed) Intelligence Processing Unit ci Continuous Integration

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants