Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 5, 2022

What does this PR do?

Upgrade the mypy job to run with torch==1.12

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Aug 5, 2022
@carmocca carmocca added this to the pl:1.8 milestone Aug 5, 2022
@carmocca carmocca self-assigned this Aug 5, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 5, 2022
@carmocca carmocca marked this pull request as ready for review August 5, 2022 12:46
@carmocca carmocca enabled auto-merge (squash) August 5, 2022 12:52
@awaelchli awaelchli mentioned this pull request Aug 5, 2022
52 tasks
@mergify mergify bot added the ready PRs ready to be merged label Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #14044 (50fe3ac) into master (91dd6a6) will increase coverage by 15%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #14044     +/-   ##
=========================================
+ Coverage      61%      76%    +15%     
=========================================
  Files         323      323             
  Lines       26319    26356     +37     
=========================================
+ Hits        16107    20117   +4010     
+ Misses      10212     6239   -3973     

@carmocca carmocca merged commit 76836a3 into master Aug 8, 2022
@carmocca carmocca deleted the ci/mypy-torch-1.12 branch August 8, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants