Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 19, 2022

What does this PR do?

Follow up to #13405

After generalizing the _SpawnLauncher to incorporate more than just the "spawn" start method, we should now rename the classes. This can be done without backward compatibility because the APIs are not user facing.

This PR should be merged using the "Rebase & Merge" option in GitHub. There should be exactly two commits:

  • Renaming the classes
  • Renaming the files

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7 @kaushikb11 @akihironitta

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 19, 2022
@awaelchli awaelchli added this to the pl:1.7 milestone Jul 19, 2022
@awaelchli awaelchli mentioned this pull request Jul 19, 2022
12 tasks
@awaelchli awaelchli force-pushed the feature/ddp-fork-rename-spawn branch from cb9e200 to 4654529 Compare July 19, 2022 22:30
Base automatically changed from feature/ddp-fork2 to master July 22, 2022 16:05
@awaelchli awaelchli force-pushed the feature/ddp-fork-rename-spawn branch from ba8f0ea to 1a09c44 Compare July 22, 2022 16:17
@awaelchli awaelchli marked this pull request as ready for review July 22, 2022 16:25
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #13743 (1a09c44) into master (c3299d2) will decrease coverage by 10%.
The diff coverage is 90%.

❗ Current head 1a09c44 differs from pull request most recent head 54da436. Consider uploading reports for the commit 54da436 to get more accurate results

@@            Coverage Diff            @@
##           master   #13743     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         327      327             
  Lines       25560    25560             
=========================================
- Hits        21969    19521   -2448     
- Misses       3591     6039   +2448     

@mergify mergify bot added the ready PRs ready to be merged label Jul 22, 2022
@awaelchli awaelchli force-pushed the feature/ddp-fork-rename-spawn branch from 54da436 to f1d2f02 Compare July 23, 2022 13:27
@awaelchli awaelchli merged commit 81f149e into master Jul 23, 2022
@awaelchli awaelchli deleted the feature/ddp-fork-rename-spawn branch July 23, 2022 15:48
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor strategy: ddp DistributedDataParallel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants