-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Rename spawn-based launchers #13743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rename spawn-based launchers #13743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb9e200 to
4654529
Compare
ba8f0ea to
1a09c44
Compare
Codecov Report
@@ Coverage Diff @@
## master #13743 +/- ##
=========================================
- Coverage 86% 76% -10%
=========================================
Files 327 327
Lines 25560 25560
=========================================
- Hits 21969 19521 -2448
- Misses 3591 6039 +2448 |
carmocca
approved these changes
Jul 22, 2022
rohitgr7
approved these changes
Jul 22, 2022
kaushikb11
approved these changes
Jul 23, 2022
justusschock
approved these changes
Jul 23, 2022
Borda
approved these changes
Jul 23, 2022
akihironitta
approved these changes
Jul 23, 2022
54da436 to
f1d2f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
refactor
strategy: ddp
DistributedDataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #13405
After generalizing the _SpawnLauncher to incorporate more than just the "spawn" start method, we should now rename the classes. This can be done without backward compatibility because the APIs are not user facing.
This PR should be merged using the "Rebase & Merge" option in GitHub. There should be exactly two commits:Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @justusschock @awaelchli @rohitgr7 @kaushikb11 @akihironitta