Skip to content

fix typing in pl/tuner/tuning.py #13616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

fix typing in pl/tuner/tuning.py #13616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7c4b7df
fix typing in pl/tuner/tuning.py
donlap Jul 12, 2022
6f51932
CI/CD: Refactor building docker images (#13576)
akihironitta Jul 12, 2022
0a6dc52
Fix mypy errors attributed to `pytorch_lightning.loggers.csv_logs.py`…
jxtngx Jul 12, 2022
57f5e18
Fix mypy errors attributed to `pytorch_lightning.loggers.base.py` (#1…
jxtngx Jul 12, 2022
e287f22
CI: Enable dependabot for GitHub Actions (#13589)
akihironitta Jul 12, 2022
b9ceefb
Fix default value for `enable_progress_bar` in docs (#13584)
JiahaoYao Jul 12, 2022
855a331
CI: Update labeler bot (#13624)
akihironitta Jul 12, 2022
dba65be
Remove redundant GPU test (#13623)
rohitgr7 Jul 12, 2022
9468866
CI: hotfix gatekeeper (#13606)
Borda Jul 12, 2022
e034cd3
Remove `add_to_queue` and `remove_from_queue` from LightningModule (#…
shenoynikhil Jul 12, 2022
01209bd
Bump codecov/codecov-action from 1 to 3 (#13620)
dependabot[bot] Jul 12, 2022
83eb901
Bump actions/upload-artifact from 2 to 3 (#13622)
dependabot[bot] Jul 12, 2022
e089ff2
Bump docker/setup-buildx-action from 1 to 2 (#13618)
dependabot[bot] Jul 12, 2022
5624674
Removed deprecated `pytorch_lightning.overrides.distributed.IndexBatc…
samz5320 Jul 13, 2022
71aefc5
change typing of tune() to TypedDict
donlap Jul 13, 2022
0fbd69b
change typing of tune() to TypedDict
donlap Jul 13, 2022
50dd785
change typing of tune() to TypedDict
donlap Jul 13, 2022
d5cfa4a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/approve_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ approvals:
minimum: 1
groups:
- name: 'PyTorch Lightning'
minimum: 0
minimum: 1
from:
- awaelchli
- Borda
Expand All @@ -16,7 +16,8 @@ approvals:
- tchaton
- williamFalcon
- name: 'Lightning Apps'
minimum: 0
minimum: 1
from:
- alecmerdler
- awaelchli
- hhsecond
Expand Down
21 changes: 19 additions & 2 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,25 @@ updates:
# Separate sections of the branch name with a hyphen
# for example, `dependabot-npm_and_yarn-next_js-acorn-6.4.1`
separator: "-"
# Allow up to 10 open pull requests for pip dependencies
# Allow up to 5 open pull requests for pip dependencies
open-pull-requests-limit: 5
reviewers:
- "Lightning-AI/teams/core-lightning"

# Enable version updates for GitHub Actions
- package-ecosystem: "github-actions"
directory: "/"
# Check for updates once a week
schedule:
interval: "monthly"
# Labels on pull requests for version updates only
labels:
- "ci"
pull-request-branch-name:
# Separate sections of the branch name with a hyphen
# for example, `dependabot-npm_and_yarn-next_js-acorn-6.4.1`
separator: "-"
# Allow up to 5 open pull requests for GitHub Actions
open-pull-requests-limit: 5
reviewers:
- "carmocca"
- "Lightning-AI/teams/core-lightning"
4 changes: 2 additions & 2 deletions .github/workflows/ci-app_examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
coverage run --source lightning_app -m pytest -m "not cloud" tests_app_examples --timeout=300 -vvvv --junitxml=$PYTEST_ARTIFACT --durations=0

- name: Upload pytest test results
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: unittest-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}
path: tests/results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}.xml
Expand All @@ -107,7 +107,7 @@ jobs:
coverage report -i

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: tests/coverage.xml
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-app_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
coverage run --source lightning_app -m pytest -m "not cloud" tests_app --timeout=300 -vvvv --junitxml=$PYTEST_ARTIFACT --durations=0

- name: Upload pytest test results
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: unittest-results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}
path: tests/results-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.requires }}.xml
Expand All @@ -114,7 +114,7 @@ jobs:
coverage report -i

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: tests/coverage.xml
Expand Down
183 changes: 0 additions & 183 deletions .github/workflows/ci-pytorch_dockers.yml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/ci-pytorch_test-conda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
run: coverage run --source pytorch_lightning -m pytest -v --timeout 150 --durations=50 --junitxml=results-${{ runner.os }}-torch${{ matrix.pytorch-version }}.xml

- name: Upload pytest results
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: unittest-results-${{ runner.os }}-torch${{ matrix.pytorch-version }}
path: tests/tests_pytorch/results-${{ runner.os }}-torch${{ matrix.pytorch-version }}.xml
Expand All @@ -93,7 +93,7 @@ jobs:
coverage xml

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v3
if: always()
# see: https://github.com/actions/toolkit/issues/399
continue-on-error: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-pytorch_test-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
run: coverage run --source pytorch_lightning -m pytest -v --durations=50 --junitxml=results-${{ runner.os }}-py${{ matrix.python-version }}-${{ matrix.requires }}-${{ matrix.release }}.xml

- name: Upload pytest results
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: unittest-results-${{ runner.os }}-py${{ matrix.python-version }}-${{ matrix.requires }}-${{ matrix.release }}
path: tests/tests_pytorch/results-${{ runner.os }}-py${{ matrix.python-version }}-${{ matrix.requires }}-${{ matrix.release }}.xml
Expand All @@ -160,7 +160,7 @@ jobs:
coverage xml

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v3
if: always()
# see: https://github.com/actions/toolkit/issues/399
continue-on-error: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-pytorch_test-slow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
PL_RUN_SLOW_TESTS: 1

- name: Upload pytest test results
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: unittest-results-${{ runner.os }}-py${{ matrix.python-version }}
path: tests/tests_pytorch/results-${{ runner.os }}-py${{ matrix.python-version }}.xml
Expand All @@ -84,7 +84,7 @@ jobs:
coverage xml

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v3
if: success()
# see: https://github.com/actions/toolkit/issues/399
continue-on-error: true
Expand Down
Loading