Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jul 11, 2022

What does this PR do?

Part of #12521.

resolves #9460

Does your PR introduce any breaking changes? If yes, please list them.

Removes support for Trainer(max_steps=None).
See the description of #9460.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @kaushikb11 @awaelchli @rohitgr7

@mergify mergify bot added the ready PRs ready to be merged label Jul 11, 2022
@akihironitta akihironitta enabled auto-merge (squash) July 13, 2022 01:25
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 13, 2022
@mergify mergify bot removed the has conflicts label Jul 14, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Jul 14, 2022
@akihironitta akihironitta merged commit 7ba0270 into master Jul 14, 2022
@akihironitta akihironitta deleted the refactor/rm-max-steps branch July 14, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change ready PRs ready to be merged trainer: argument

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants