-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix mypy errors attributed to pytorch_lightning/loops/epoch/training_epoch_loop.py #13555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mypy errors attributed to pytorch_lightning/loops/epoch/training_epoch_loop.py #13555
Conversation
for more information, see https://pre-commit.ci
|
|
…htning into mypy-training_epoch_loop
|
https://github.com/Lightning-AI/lightning/runs/7235310789?check_suite_focus=true#step:18:727 It doesn't reproduce on my local environment... 😢 |
carmocca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after comments addressed
|
Thank you so much for all reviewers! I just revised the PR again, PTAL. cc. @carmocca |
What does this PR do?
Part of #13445. Fixing mypy complaints in
training_epoch_loop.py.Before
After
Does your PR introduce any breaking changes? If yes, please list them.
RuntimeErrorif users attempt to useReduceLROnPlateauwithout monitorReduceLROnPlateauBefore submitting
[ ] Did you make sure to update the documentation with your changes? (if necessary)[ ] Did you write any new necessary tests? (not for typos and docs)[ ] Did you list all the breaking changes introduced by this pull request?PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Enjoying mypy puzzle 🤗