Skip to content

CI: fix requirements freeze #13441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 29, 2022
Merged

CI: fix requirements freeze #13441

merged 5 commits into from
Jun 29, 2022

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jun 29, 2022 •
edited by github-actions bot
Loading

What does this PR do?

after installation of the package itself, we broke freezing requirements so silently we were always using latest always... :)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @carmocca @akihironitta

@Borda Borda added the ci Continuous Integration label Jun 29, 2022
@Borda Borda marked this pull request as ready for review June 29, 2022 07:02
@Borda Borda added the priority: 0 High priority task label Jun 29, 2022
@Borda Borda added this to the pl:1.6.x milestone Jun 29, 2022
tchaton
tchaton approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat !

@kaushikb11 kaushikb11 enabled auto-merge (squash) June 29, 2022 08:02
@mergify mergify bot added the ready PRs ready to be merged label Jun 29, 2022
@Borda Borda mentioned this pull request Jun 29, 2022
Closed
8 tasks
@lexierule lexierule disabled auto-merge June 29, 2022 13:35
@lexierule lexierule merged commit b137ef7 into master Jun 29, 2022
@lexierule lexierule deleted the ci/freeze-req branch June 29, 2022 13:35
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
@Borda @pre-commit-ci @jerome-habana
CI: fix requirements freeze (Lightning-AI#13441)
c1ad298 
* allow freeze

* ci

* typo

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* ipu

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@akihironitta akihironitta Awaiting requested review from akihironitta

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

+4 more reviewers

@otaj otaj otaj approved these changes

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.6.x

Development

Successfully merging this pull request may close these issues.

7 participants

@Borda @otaj @carmocca @tchaton @rohitgr7 @kaushikb11 @lexierule