Skip to content

Update deepspeed requirement from <0.6.0 to <0.7.0 in /requirements #13367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update deepspeed requirement from <0.6.0 to <0.7.0 in /requirements #13367

wants to merge 1 commit into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 22, 2022 •
edited
Loading

Updates the requirements on deepspeed to permit the latest version.

Release notes

Sourced from deepspeed's releases.

v0.6.5: Patch release

What's Changed

New Contributors

Full Changelog: deepspeedai/DeepSpeed@v0.6.4...v0.6.5

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

cc @Borda @carmocca @akihironitta

@dependabot dependabot bot added the ci Continuous Integration label Jun 22, 2022
@dependabot dependabot bot requested a review from a team June 22, 2022 11:23
@Borda Borda added this to the pl:1.7 milestone Jun 22, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jun 22, 2022
@akihironitta
Copy link
Contributor

akihironitta commented Jun 22, 2022

We should wait for #13198 before we update deepspeed here because upgrading packages that are only used in GPU CI can be verified only after a new docker image is pushed to the hub from master branch. We've had an issue before as commented by @carmocca #13048 (comment).

@Borda
Copy link
Collaborator

Borda commented Jun 22, 2022

We should wait for #13198 before we update deepspeed here because upgrading packages that are only used in GPU CI can be verified only after a new docker image is pushed to the hub from master branch. We've had an issue before as commented by @carmocca #13048 (comment).

so pls make it as requested changes :)

akihironitta
akihironitta suggested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per my comment above.

@mergify mergify bot removed the ready PRs ready to be merged label Jun 22, 2022
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-deepspeed-lt-0.7.0 branch from e65fced to 4b02e1a Compare July 4, 2022 16:34
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-deepspeed-lt-0.7.0 branch 3 times, most recently from 6428992 to 620f028 Compare July 14, 2022 09:31
@dependabot
Update deepspeed requirement from <0.6.0 to <0.7.0 in /requirements
5aa023a 
Updates the requirements on [deepspeed](https://github.com/microsoft/DeepSpeed) to permit the latest version.
- [Release notes](https://github.com/microsoft/DeepSpeed/releases)
- [Commits](deepspeedai/DeepSpeed@v0.1.0...v0.6.5)

---
updated-dependencies:
- dependency-name: deepspeed
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot-pip-requirements-deepspeed-lt-0.7.0 branch from 620f028 to 5aa023a Compare July 14, 2022 10:23
@akihironitta
Copy link
Contributor

akihironitta commented Jul 14, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 14, 2022

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@carmocca carmocca modified the milestones: pl:1.7, pl:future Jul 19, 2022
@carmocca
Copy link
Contributor

carmocca commented Jul 19, 2022

Closing in favor of #13191

@carmocca carmocca closed this Jul 19, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 19, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@carmocca carmocca deleted the dependabot-pip-requirements-deepspeed-lt-0.7.0 branch July 19, 2022 17:55
@carmocca
Copy link
Contributor

carmocca commented Jul 19, 2022

@dependabot ignore this minor version

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 19, 2022

OK, I won't notify you about version 0.6.x again, unless you re-open this PR or update to a 0.6.x release yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

+2 more reviewers

@akihironitta akihironitta akihironitta requested changes

@SeanNaren SeanNaren SeanNaren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci Continuous Integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@akihironitta @Borda @carmocca @SeanNaren