Update deepspeed and fairscale versions
#12860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Borda
reviewed
Apr 23, 2022
akihironitta
requested review from
SeanNaren,
awaelchli,
justusschock,
kaushikb11,
rohitgr7 and
williamFalcon
as code owners
akihironitta
changed the title
deepspeed>=0.6.0deepspeed and fairscale versions
akihironitta
commented
Apr 23, 2022
| python -c "fname = 'requirements/extra.txt' ; lines = [line for line in open(fname).readlines() if 'horovod' not in line] ; open(fname, 'w').writelines(lines)" | ||
| pip install fairscale>=0.4.5 | ||
| pip install deepspeed>=0.6.0 | ||
| pip install "fairscale>=0.4.5" |
Contributor
Author
There was a problem hiding this comment.
For people dealing with CI/CD:
The command here was not appropriate! It just redirects stdout from pip install fairscale into a file named =0.4.5 and leads to installing the wrong versions, so make sure to put "" when specifying versions :)
- pip install fairscale>=0.4.5
+ pip install "fairscale>=0.4.5"
Collaborator
There was a problem hiding this comment.
yep, I know, it just creates a file 0.4.5 :D
awaelchli
approved these changes
Apr 24, 2022
rohitgr7
approved these changes
Apr 25, 2022
kaushikb11
approved these changes
Apr 25, 2022
This reverts commit cb5a0ce.
12 tasks
Contributor
Author
|
@carmocca @Borda Addressed @awaelchli's comment. Could you have another look? |
Borda
approved these changes
Apr 25, 2022
otaj
pushed a commit
that referenced
this pull request
Apr 26, 2022
* Fix deepspeed installation * Adapt to deepspeed>=0.5.9 * Fix fairscale installation Co-authored-by: Akihiro Nitta <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Fix deepspeed installation * Adapt to deepspeed>=0.5.9 * Fix fairscale installation Co-authored-by: Akihiro Nitta <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #12373.
0.5.7to0.5.10 (as of now)and avoids using0.6.{0,1}due to DeepSpeed v1.6.1 issues with Pytorch Lightning Deep Speed 3 Offloading deepspeedai/DeepSpeed#18780.4.0to0.4.6 (as of now)>=0.5.9. The change in DeepSpeed API was introduced in Refactor ZeRO naming to reduce confusion deepspeedai/DeepSpeed#1607.Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @Borda @SeanNaren @awaelchli @rohitgr7