Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Mar 30, 2022

What does this PR do?

Part of #12521
required for: #11822

resolves #8989

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @justusschock @kaushikb11 @awaelchli @rohitgr7 @tchaton

@rohitgr7 rohitgr7 added deprecation Includes a deprecation callback: swa labels Mar 30, 2022
@rohitgr7 rohitgr7 added this to the 1.7 milestone Mar 30, 2022
@rohitgr7 rohitgr7 self-assigned this Mar 30, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review March 30, 2022 17:53
@ananthsub ananthsub added breaking change Includes a breaking change trainer: argument and removed deprecation Includes a deprecation labels Mar 30, 2022
@rohitgr7 rohitgr7 changed the title Remove deprecated stochastic_weight_averaging flag from Trainer Remove deprecated stochastic_weight_averaging flag from Trainer Mar 30, 2022
@rohitgr7
Copy link
Contributor Author

@ananthsub how is this a breaking change?

@kaushikb11
Copy link
Contributor

@rohitgr7 It would be a breaking change for the users as we are removing the Trainer flag.

Co-authored-by: ananthsub <[email protected]>
@mergify mergify bot added the ready PRs ready to be merged label Mar 31, 2022
@ananthsub ananthsub changed the title Remove deprecated stochastic_weight_averaging flag from Trainer Remove deprecated stochastic_weight_avg flag from Trainer Mar 31, 2022
Co-authored-by: ananthsub <[email protected]>
@rohitgr7 rohitgr7 changed the title Remove deprecated stochastic_weight_avg flag from Trainer Remove deprecated stochastic_weight_avg argument from Trainer Mar 31, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) March 31, 2022 09:18
@rohitgr7 rohitgr7 merged commit 84c5b62 into master Mar 31, 2022
@rohitgr7 rohitgr7 deleted the remove/swa_flag branch March 31, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change callback: swa ready PRs ready to be merged refactor trainer: argument

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants