Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Mar 25, 2022

What does this PR do?

Fixes #12418 (comment)

This is a callback so saving should be entirely managed by hooks.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @tchaton @rohitgr7 @carmocca @awaelchli @ninginthecloud @jjenniferdai

@mergify mergify bot added the ready PRs ready to be merged label Mar 27, 2022
@carmocca carmocca enabled auto-merge (squash) March 28, 2022 13:10
@carmocca carmocca merged commit 334675e into master Mar 28, 2022
@carmocca carmocca deleted the deprecate/mc-save-ckpt branch March 28, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback: model checkpoint deprecation Includes a deprecation ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants