Skip to content

Conversation

@ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Mar 8, 2022

What does this PR do?

Follow up to comment here: #11952 (comment)

Currently we are calling LightningModule.configure_optimizers 3 times in the FSDP strategy 😞
We only need to do this one, after the model is wrapped with FSDP inside of model_sharded_context

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub force-pushed the fix/improve-fsdp-opt branch from ccefee2 to c81a477 Compare March 11, 2022 03:25
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Mar 16, 2022
@awaelchli awaelchli enabled auto-merge (squash) March 20, 2022 16:14
@mergify mergify bot removed the has conflicts label Mar 20, 2022
@awaelchli awaelchli merged commit d99625f into Lightning-AI:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged strategy: fairscale fsdp (removed) Fully Sharded Data Parallel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants