Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 17, 2022

What does this PR do?

#8578 requires using the checkpoint connector to manage the trainer state before and after tuning.

Part of #8578

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @awaelchli @ananthsub @ninginthecloud @rohitgr7 @akihironitta @Borda @carmocca @justusschock

@carmocca carmocca added this to the 1.6 milestone Jan 17, 2022
@carmocca carmocca self-assigned this Jan 17, 2022
@carmocca carmocca requested a review from rohitgr7 January 18, 2022 16:55
@carmocca carmocca changed the title Reset the tuner state with the checkpoint connector Fix checkpoint values when saving and resetting the tuner state Jan 18, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jan 19, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) January 20, 2022 17:51
@tchaton tchaton merged commit 075b880 into master Jan 20, 2022
@tchaton tchaton deleted the feature/tuner-ckpt-connector branch January 20, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

checkpointing Related to checkpointing fault tolerance ready PRs ready to be merged tuner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants