Skip to content

Fix BF16 teardown for TPU precision plugin #10990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 131 commits into from
Dec 22, 2021
Merged

Fix BF16 teardown for TPU precision plugin #10990

merged 131 commits into from
Dec 22, 2021

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 8, 2021 •
edited by github-actions bot
Loading

What does this PR do?

The env variable gets set in the tpu bf16 precision plugin connect() method but gets deleted again in the TPUSpawnPlugin before training starts. The correct behavior is to set the variable at the beginning of a run and remove it again at the end of a run (teardown). For this reason, we are introducing a teardown() method on the PrecisionPlugin base class (missing so far due to lack of use case).

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs) 2/n Simplify spawn plugins: Spawn immediately #10896
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @kaushikb11

awaelchli and others added 30 commits October 20, 2021 04:53
@awaelchli
improve spawn queue
d05363f
@awaelchli
clean up
d650e26
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5fda23a 
for more information, see https://pre-commit.ci
@awaelchli
Merge branch 'master' into feature/simple-spawn
d6b4a34
@awaelchli
fix
bcfb853
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
97b4bf6 
for more information, see https://pre-commit.ci
@awaelchli
rename
38b3a54
@awaelchli
delete dead code
955b6c8
@awaelchli
Merge remote-tracking branch 'origin/feature/simple-spawn' into featu…
13393e8 
…re/simple-spawn
@awaelchli
clean up
f3216b2
@awaelchli
update lite
2d00231
@awaelchli
retain the queue interface in hooks
7aa3646
@awaelchli
update tests
fb0c0d8
@awaelchli
Merge branch 'master' into feature/simple-spawn
1bc59ae
@awaelchli
_notebooks
7e6c75e
@awaelchli
reset notebooks
b7efc50
@awaelchli
avoid circular import
84ca8b4
@awaelchli
fix unused imports
965c724
@awaelchli
reset debugging script
1aae8dd
@awaelchli
typing _ExtraQueue
4b998db
@awaelchli
bring changes to tpu_spawn plugin
5871a4b
@awaelchli
unify
aa76840
@awaelchli
remove dead code
37f9db9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d68cb35 
for more information, see https://pre-commit.ci
@awaelchli
remove queue from tpu spawn
dd80be9
@awaelchli
type annotation for new_process
f97eee8
@awaelchli
Merge remote-tracking branch 'origin/feature/simple-spawn' into refac…
ad61d27 
…tor/spawn/simple-spawn
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
459121e 
for more information, see https://pre-commit.ci
@awaelchli
unused imports
72535ff
@awaelchli
Merge remote-tracking branch 'origin/feature/simple-spawn' into refac…
3095da9 
…tor/spawn/simple-spawn
@mergify mergify bot added ready PRs ready to be merged has conflicts labels Dec 14, 2021
carmocca
carmocca reviewed Dec 14, 2021
View reviewed changes
@awaelchli awaelchli mentioned this pull request Dec 16, 2021
Closed
@mergify mergify bot removed the has conflicts label Dec 21, 2021
tchaton
tchaton approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

kaushikb11 and others added 2 commits December 21, 2021 14:15
@kaushikb11 @tchaton
Update CHANGELOG.md
7561465 
Co-authored-by: thomas chaton <[email protected]>
@kaushikb11 @tchaton
Update CHANGELOG.md
990063b 
Co-authored-by: thomas chaton <[email protected]>
@mergify mergify bot removed the has conflicts label Dec 21, 2021
@mergify mergify bot removed the has conflicts label Dec 22, 2021
@awaelchli awaelchli enabled auto-merge (squash) December 22, 2021 03:13
@awaelchli awaelchli merged commit ba8e7cd into master Dec 22, 2021
@awaelchli awaelchli deleted the bugfix/bf16-env-variable branch December 22, 2021 03:47
awaelchli added a commit that referenced this pull request Jan 4, 2022
@awaelchli @pre-commit-ci
@justusschock @rohitgr7 @kaushikb11 @tchaton
Fix BF16 teardown for TPU precision plugin (#10990)
775b712 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Kaushik B <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
awaelchli added a commit that referenced this pull request Jan 5, 2022
@awaelchli @pre-commit-ci
@justusschock @rohitgr7 @kaushikb11 @tchaton
Fix BF16 teardown for TPU precision plugin (#10990)
f69bb3a 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
Co-authored-by: Kaushik B <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
@awaelchli awaelchli mentioned this pull request Jan 5, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+4 more reviewers

@carmocca carmocca carmocca approved these changes

@kaushikb11 kaushikb11 kaushikb11 left review comments

@ananthsub ananthsub ananthsub approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

accelerator: tpu Tensor Processing Unit bug Something isn't working ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.5.x

Development

Successfully merging this pull request may close these issues.

7 participants

@awaelchli @ananthsub @Borda @carmocca @tchaton @rohitgr7 @kaushikb11