Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 30, 2021

What does this PR do?

Found while working on #10034, #10059.
This was missed in #9118

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @carmocca @JackCaoG @Liyang90 @gkroiz @tchaton @justusschock @awaelchli @kaushikb11

@awaelchli awaelchli added this to the 1.6 milestone Nov 30, 2021
@awaelchli awaelchli added accelerator: tpu Tensor Processing Unit deprecation Includes a deprecation strategy: ddp spawn labels Nov 30, 2021
@awaelchli awaelchli marked this pull request as ready for review November 30, 2021 23:22
@mergify mergify bot added the ready PRs ready to be merged label Dec 1, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli enabled auto-merge (squash) December 1, 2021 14:42
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #10854 (c349cf0) into master (f3b0a06) will increase coverage by 2%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #10854    +/-   ##
========================================
+ Coverage      88%      90%    +2%     
========================================
  Files         177      177            
  Lines       16553    16555     +2     
========================================
+ Hits        14570    14948   +378     
+ Misses       1983     1607   -376     

@awaelchli awaelchli merged commit 3a8b3fc into master Dec 1, 2021
@awaelchli awaelchli deleted the refactor/spawn/user-queue branch December 1, 2021 15:46
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: tpu Tensor Processing Unit deprecation Includes a deprecation ready PRs ready to be merged strategy: ddp DistributedDataParallel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants