Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 30, 2021

What does this PR do?

Replaces save() and pl_load() instructions in the strategy with a call to the CheckpointIO plugin.

Part of #10034, #10059

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @carmocca @JackCaoG @Liyang90 @gkroiz @justusschock @awaelchli @kaushikb11 @akihironitta

@awaelchli awaelchli changed the title Save with CheckpointIO plugin in DDPSpawn plugins Save with CheckpointIO in DDPSpawn plugins Nov 30, 2021
@awaelchli awaelchli added this to the 1.6 milestone Nov 30, 2021
@awaelchli awaelchli changed the title Save with CheckpointIO in DDPSpawn plugins Save and load with CheckpointIO in DDPSpawn plugins Nov 30, 2021
@awaelchli awaelchli marked this pull request as ready for review November 30, 2021 16:45
@mergify mergify bot added the ready PRs ready to be merged label Nov 30, 2021
@four4fish
Copy link
Contributor

Great! I was wondering why spawning was using atomic_save directly without go through checkpoint io.

@awaelchli awaelchli enabled auto-merge (squash) November 30, 2021 17:27
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #10846 (e48b234) into master (8e1b9b3) will increase coverage by 0%.
The diff coverage is 33%.

❗ Current head e48b234 differs from pull request most recent head 0d04070. Consider uploading reports for the commit 0d04070 to get more accurate results

@@           Coverage Diff           @@
##           master   #10846   +/-   ##
=======================================
  Coverage      90%      90%           
=======================================
  Files         177      177           
  Lines       16512    16504    -8     
=======================================
+ Hits        14910    14912    +2     
+ Misses       1602     1592   -10     

@awaelchli awaelchli merged commit 32e6522 into master Nov 30, 2021
@awaelchli awaelchli deleted the refactor/spawn/save-special-ckpt branch November 30, 2021 20:31
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: tpu Tensor Processing Unit ready PRs ready to be merged refactor strategy: ddp DistributedDataParallel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants