Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Nov 11, 2021

What does this PR do?

Finishes and fixes #10312

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 changed the title remove deprecated reload_dataloaders_every_epoch remove deprecated reload_dataloaders_every_epoch from Trainer Nov 11, 2021
@rohitgr7 rohitgr7 self-assigned this Nov 11, 2021
@rohitgr7 rohitgr7 added this to the 1.6 milestone Nov 11, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review November 12, 2021 07:05
@mergify mergify bot added the ready PRs ready to be merged label Nov 12, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) November 12, 2021 10:23
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #10481 (6f8f4ad) into master (6dfcb6a) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10481   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         178      178           
  Lines       16243    16240    -3     
=======================================
  Hits        14904    14904           
+ Misses       1339     1336    -3     

@rohitgr7 rohitgr7 merged commit de7ef41 into master Nov 16, 2021
@rohitgr7 rohitgr7 deleted the remove/rdee branch November 16, 2021 06:47
enable_progress_bar=False,
enable_model_summary=False,
reload_dataloaders_every_epoch=True,
reload_dataloaders_every_n_epochs=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this need to be an int?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated code after the 1.5 release

6 participants