-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove deprecated mode argument from ModelSummary
#10449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananthsub
reviewed
Nov 10, 2021
ananthsub
reviewed
Nov 10, 2021
Contributor
|
Hey @kaushikb11, I had #10446 already opened. Do you mind merging that and then fully removing the argument here? |
kaushikb11
commented
Nov 12, 2021
rohitgr7
approved these changes
Nov 12, 2021
kaushikb11
commented
Nov 12, 2021
awaelchli
approved these changes
Nov 12, 2021
carmocca
approved these changes
Nov 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #10449 +/- ##
========================================
- Coverage 92% 89% -4%
========================================
Files 179 179
Lines 16288 16273 -15
========================================
- Hits 15060 14418 -642
- Misses 1228 1855 +627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
deprecation
Includes a deprecation
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #10312
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃