Skip to content

Conversation

@kaushikb11
Copy link
Contributor

What does this PR do?

Part of #10312

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added the deprecation Includes a deprecation label Nov 10, 2021
@kaushikb11 kaushikb11 added this to the 1.6 milestone Nov 10, 2021
@kaushikb11 kaushikb11 added the breaking change Includes a breaking change label Nov 10, 2021
@carmocca
Copy link
Contributor

Hey @kaushikb11, I had #10446 already opened. Do you mind merging that and then fully removing the argument here?

@mergify mergify bot removed the has conflicts label Nov 12, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) November 12, 2021 08:58
@mergify mergify bot added the ready PRs ready to be merged label Nov 12, 2021
@mergify mergify bot removed the has conflicts label Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #10449 (87e0f73) into master (fa0ed17) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10449    +/-   ##
========================================
- Coverage      92%      89%    -4%     
========================================
  Files         179      179            
  Lines       16288    16273    -15     
========================================
- Hits        15060    14418   -642     
- Misses       1228     1855   +627     

@kaushikb11 kaushikb11 merged commit fabb364 into master Nov 12, 2021
@kaushikb11 kaushikb11 deleted the remove/mode branch November 12, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Includes a breaking change deprecation Includes a deprecation ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants