Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Nov 2, 2021

What does this PR do?

Currently the "pulse" animation is used for all progress. This should only be enabled for iterable datasets. If not using iterable datasets, we should use the standard progress bar. This was included in #9647 but needs to be in for the release!

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the bug Something isn't working label Nov 2, 2021
@SeanNaren SeanNaren added this to the v1.5 milestone Nov 2, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 2, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) November 2, 2021 10:16
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #10305 (c27bdcf) into master (f44b8a7) will increase coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #10305    +/-   ##
========================================
+ Coverage      89%      93%    +4%     
========================================
  Files         182      182            
  Lines       16487    16487            
========================================
+ Hits        14624    15255   +631     
+ Misses       1863     1232   -631     

@SeanNaren SeanNaren merged commit 1686aab into master Nov 2, 2021
@SeanNaren SeanNaren deleted the fix/rich_pulse branch November 2, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants