Skip to content

Conversation

@daniellepintz
Copy link
Contributor

What does this PR do?

Fixes #10109

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz changed the title Deprecate debugging_connector.py Remove debugging_connector.py Oct 25, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@awaelchli awaelchli added this to the v1.5 milestone Oct 27, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 27, 2021
@daniellepintz daniellepintz enabled auto-merge (squash) October 27, 2021 17:46
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #10113 (b4617e8) into master (dbe1662) will decrease coverage by 0%.
The diff coverage is 100%.

❗ Current head b4617e8 differs from pull request most recent head 2350854. Consider uploading reports for the commit 2350854 to get more accurate results

@@           Coverage Diff           @@
##           master   #10113   +/-   ##
=======================================
- Coverage      89%      89%   -0%     
=======================================
  Files         180      181    +1     
  Lines       16146    16102   -44     
=======================================
- Hits        14317    14265   -52     
- Misses       1829     1837    +8     

@mergify mergify bot removed the has conflicts label Oct 29, 2021
@mergify mergify bot removed the has conflicts label Oct 29, 2021
@daniellepintz
Copy link
Contributor Author

I am confused why mypy is failing:
pytorch_lightning/plugins/precision/precision_plugin.py:147: error: Cannot determine type of "track_grad_norm" [has-type]
anyone have any ideas? It seems to have to do with #10112, but I don't see what the problem is

@carmocca
Copy link
Contributor

@daniellepintz Fixed by merging master 🤗

@daniellepintz daniellepintz merged commit cb8a216 into Lightning-AI:master Oct 30, 2021
@daniellepintz daniellepintz deleted the debug_con branch October 30, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move code from debugging_connector to trainer.py

7 participants