-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove debugging_connector.py
#10113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
debugging_connector.pydebugging_connector.py
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
Codecov Report
@@ Coverage Diff @@
## master #10113 +/- ##
=======================================
- Coverage 89% 89% -0%
=======================================
Files 180 181 +1
Lines 16146 16102 -44
=======================================
- Hits 14317 14265 -52
- Misses 1829 1837 +8 |
|
I am confused why mypy is failing: |
|
@daniellepintz Fixed by merging master 🤗 |
What does this PR do?
Fixes #10109
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃