Skip to content

Improve manual_optimization #5769

@tchaton

Description

@tchaton

🚀 Feature

Motivation

The current manual optimization is not flexible enough.
From discussion with @justusschock and @awaelchli, here is the proposal:

  • manual_backward shouldn't take any optimizers as they aren't used internally expect in Horovod. To solve this, in Horovod, call synchronise on all optimizers.
  • In LightningOptimizer, optimizer shoudn't follow accumulated_grad_batches.

Pitch

Alternatives

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureIs an improvement or enhancementhelp wantedOpen to be worked on

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions