Skip to content

Commit f911f37

Browse files
committed
Update deprecation versions
1 parent 4f92fba commit f911f37

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pytorch_lightning/trainer/connectors/profiler_connector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def on_trainer_init(self, profiler: Union[BaseProfiler, bool, str]):
3434

3535
if isinstance(profiler, bool):
3636
rank_zero_warn("Passing a bool value as a `profiler` argument to `Trainer` is deprecated"
37-
" and will be removed in v1.2.0. Use str ('simple' or 'advanced') instead.",
37+
" and will be removed in v1.3. Use str ('simple' or 'advanced') instead.",
3838
DeprecationWarning)
3939
if profiler:
4040
profiler = SimpleProfiler()

tests/test_deprecated.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ def test_tbd_remove_in_v1_2_0():
2626
checkpoint_cb = ModelCheckpoint(filepath='.', dirpath='.')
2727

2828

29-
# TODO: remove bool from Trainer.profiler param in v1.2.0, update profiler_connector.py
29+
# TODO: remove bool from Trainer.profiler param in v1.3.0, update profiler_connector.py
3030
@pytest.mark.parametrize(['profiler', 'expected'], [
3131
(True, SimpleProfiler),
3232
(False, PassThroughProfiler),
3333
])
34-
def test_trainer_profiler_remove_in_v1_2_0(profiler, expected):
35-
with pytest.deprecated_call(match='will be removed in v1.2.0'):
34+
def test_trainer_profiler_remove_in_v1_3_0(profiler, expected):
35+
with pytest.deprecated_call(match='will be removed in v1.3'):
3636
trainer = Trainer(profiler=profiler)
3737
assert isinstance(trainer.profiler, expected)
3838

@@ -45,7 +45,7 @@ def test_trainer_profiler_remove_in_v1_2_0(profiler, expected):
4545
('--profiler False', False, PassThroughProfiler),
4646
],
4747
)
48-
def test_trainer_cli_profiler_remove_in_v1_2_0(cli_args, expected_parsed_arg, expected_profiler):
48+
def test_trainer_cli_profiler_remove_in_v1_3_0(cli_args, expected_parsed_arg, expected_profiler):
4949
cli_args = cli_args.split(' ')
5050
with mock.patch("argparse._sys.argv", ["any.py"] + cli_args):
5151
parser = ArgumentParser(add_help=False)

0 commit comments

Comments
 (0)