Skip to content

Commit f8082a3

Browse files
authored
Merge branch 'release/1.2-dev' into patch-2
2 parents 44e7433 + 23c241d commit f8082a3

18 files changed

+33
-47
lines changed

pyproject.toml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ known_first_party = [
2323
"tests",
2424
]
2525
skip_glob = [
26-
27-
2826
# todo
2927
"pytorch_lightning/accelerators/*",
3028

@@ -75,22 +73,6 @@ skip_glob = [
7573

7674
# todo
7775
"pytorch_lightning/utilities/*",
78-
79-
80-
# todo
81-
"tests/backends/*",
82-
83-
84-
# todo
85-
"tests/base/*",
86-
87-
88-
# todo
89-
"tests/tuner/*",
90-
91-
92-
# todo
93-
"tests/utilities/*",
9476
]
9577
profile = "black"
9678
line_length = 120

pytorch_lightning/loggers/comet.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
from torch import is_tensor
2626

2727
from pytorch_lightning import _logger as log
28+
from pytorch_lightning.core.lightning import LightningModule
2829
from pytorch_lightning.loggers.base import LightningLoggerBase, rank_zero_experiment
2930
from pytorch_lightning.utilities import rank_zero_only, _module_available
3031
from pytorch_lightning.utilities.exceptions import MisconfigurationException
@@ -310,3 +311,7 @@ def __getstate__(self):
310311
# needed later
311312
state["_experiment"] = None
312313
return state
314+
315+
def log_graph(self, model: LightningModule, input_array=None) -> None:
316+
if self._experiment is not None:
317+
self._experiment.set_model_graph(model)

tests/backends/ddp_model.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717
import os
1818
from argparse import ArgumentParser
1919

20-
from pytorch_lightning import Trainer, seed_everything
21-
from tests.base import EvalModelTemplate
22-
2320
import torch
2421

22+
from pytorch_lightning import seed_everything, Trainer
23+
from tests.base import EvalModelTemplate
24+
2525

2626
def main():
2727
seed_everything(1234)

tests/backends/test_accelerator_connector.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
import pytest
1919

20-
from pytorch_lightning import Trainer, accelerators
20+
from pytorch_lightning import accelerators, Trainer
2121
from pytorch_lightning.accelerators import Accelerator
2222
from pytorch_lightning.callbacks import Callback
2323
from pytorch_lightning.cluster_environments import ClusterEnvironment, SLURMEnvironment, TorchElasticEnvironment

tests/backends/test_ddp.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616
import pytest
1717
import torch
1818

19-
from tests.backends import ddp_model
20-
from tests.backends import DDPLauncher
19+
from tests.backends import ddp_model, DDPLauncher
2120
from tests.utilities.distributed import call_training_script
2221

2322

tests/backends/test_ddp_spawn.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717
import tests.base.develop_pipelines as tpipes
1818
import tests.base.develop_utils as tutils
1919
from pytorch_lightning.callbacks import EarlyStopping
20-
from pytorch_lightning.trainer.states import TrainerState
21-
from tests.base import EvalModelTemplate
2220
from pytorch_lightning.core import memory
2321
from pytorch_lightning.trainer import Trainer
22+
from pytorch_lightning.trainer.states import TrainerState
23+
from tests.base import EvalModelTemplate
2424

2525

2626
@pytest.mark.skipif(torch.cuda.device_count() < 2, reason="test requires multi-GPU machine")

tests/backends/test_dp.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,12 @@
1414
import pytest
1515
import torch
1616

17+
import pytorch_lightning as pl
1718
import tests.base.develop_pipelines as tpipes
1819
import tests.base.develop_utils as tutils
1920
from pytorch_lightning.callbacks import EarlyStopping
2021
from pytorch_lightning.core import memory
2122
from tests.base import EvalModelTemplate
22-
import pytorch_lightning as pl
23-
2423

2524
PRETEND_N_OF_GPUS = 16
2625

tests/base/datamodules.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,12 @@
1313
# limitations under the License.
1414
from typing import Any, Dict, Optional
1515

16-
from pytorch_lightning.core.datamodule import LightningDataModule
17-
from tests.base.datasets import MNIST, TrialMNIST
1816
from torch.utils.data import DataLoader, random_split
1917
from torch.utils.data.distributed import DistributedSampler
2018

19+
from pytorch_lightning.core.datamodule import LightningDataModule
20+
from tests.base.datasets import MNIST, TrialMNIST
21+
2122

2223
class TrialMNISTDataModule(LightningDataModule):
2324
def __init__(self, data_dir: str = "./"):

tests/base/datasets.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import random
1717
import time
1818
import urllib.request
19-
from typing import Tuple, Optional, Sequence
19+
from typing import Optional, Sequence, Tuple
2020

2121
import torch
2222
from torch import Tensor

tests/base/deterministic_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# limitations under the License.
1414
import torch
1515
from torch import nn
16-
from torch.utils.data import Dataset, DataLoader
16+
from torch.utils.data import DataLoader, Dataset
1717

1818
from pytorch_lightning.core.lightning import LightningModule
1919
from pytorch_lightning.utilities import DistributedType

0 commit comments

Comments
 (0)