Merge branch 'master' into refactor/remove-check-ckpt-callback

Author: awaelchli

docs/source/api_references.rst

@@ -122,6 +122,7 @@ Cluster Environments
 
     ClusterEnvironment
     LightningEnvironment
+    LSFEnvironment
     TorchElasticEnvironment
     KubeflowEnvironment
     SLURMEnvironment

pytorch_lightning/loops/epoch/training_epoch_loop.py

@@ -221,6 +221,8 @@ def on_run_end(self) -> List[List[STEP_OUTPUT]]:
         self.trainer.call_hook('on_epoch_end')
         self.trainer.logger_connector.on_epoch_end()
 
+        self.update_lr_schedulers('epoch', update_plateau_schedulers=True)
+
         epoch_output = self._epoch_output
         # free memory
         self._epoch_output = None

pytorch_lightning/loops/fit_loop.py

@@ -227,13 +227,6 @@ def advance(self) -> None:
             self.trainer.logger_connector.update_train_epoch_metrics()
             self.global_step += 1
 
-    def on_advance_end(self) -> None:
-        """Updates the LR schedulers and does some internal bookkeeping"""
-        if self.epoch_loop.batches_seen == 0:
-            return
-
-        self.epoch_loop.update_lr_schedulers('epoch', update_plateau_schedulers=True)
-
     def on_run_end(self) -> None:
         """Calls the ``on_train_end`` hook"""
         # NOTE: the iteration_count/current_epoch is already incremented