Skip to content

Commit e1a44b5

Browse files
committed
ddp as extra script
1 parent 7865fdb commit e1a44b5

File tree

3 files changed

+32
-19
lines changed

3 files changed

+32
-19
lines changed

.drone.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ steps:
4343
- sh tests/special_tests.sh
4444
- coverage report
4545
- python -m pytest benchmarks pl_examples -v --maxfail=2 --durations=0
46+
- pl_examples/run_ddp-example.sh
4647
# see: https://docs.codecov.io/docs/merging-reports
4748
- codecov --token $CODECOV_TOKEN --flags=gpu,pytest --name="GPU-coverage" --env=linux --build $DRONE_BUILD_NUMBER --commit $DRONE_COMMIT
4849
# --build $DRONE_BUILD_NUMBER --branch $DRONE_BRANCH --commit $DRONE_COMMIT --tag $DRONE_TAG --pr $DRONE_PULL_REQUEST

pl_examples/run_ddp-example.sh

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#!/bin/bash
2+
3+
ARGS_DEFAULT=" --default_root_dir %(tmpdir)s --max_epochs 1 --batch_size 32 --limit_train_batches 2 --limit_val_batches 2"
4+
ARGS_EXTRA_DDP=" --gpus 2 --accelerator ddp"
5+
ARGS_EXTRA_AMP=" --precision 16"
6+
7+
python pl_examples/basic_examples/simple_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP}
8+
python pl_examples/basic_examples/simple_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP} ${ARGS_EXTRA_AMP}
9+
python pl_examples/basic_examples/backbone_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP}
10+
python pl_examples/basic_examples/backbone_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP} ${ARGS_EXTRA_AMP}
11+
python pl_examples/basic_examples/autoencoder.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP}
12+
python pl_examples/basic_examples/autoencoder.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP} ${ARGS_EXTRA_AMP}

pl_examples/test_examples.py

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@
3838
--accelerator dp \
3939
"""
4040

41-
ARGS_DDP = ARGS_DEFAULT + """
42-
--gpus 2 \
43-
--accelerator ddp_spawn \
44-
"""
41+
# ARGS_DDP = ARGS_DEFAULT + """
42+
# --gpus 2 \
43+
# --accelerator ddp_spawn \
44+
# """
4545

4646
ARGS_AMP = """
4747
--precision 16 \
@@ -65,21 +65,21 @@ def test_examples_dp(tmpdir, import_cli, cli_args):
6565
module.cli_main()
6666

6767

68-
@pytest.mark.parametrize('import_cli', [
69-
'pl_examples.basic_examples.simple_image_classifier',
70-
'pl_examples.basic_examples.backbone_image_classifier',
71-
'pl_examples.basic_examples.autoencoder',
72-
])
73-
@pytest.mark.skipif(torch.cuda.device_count() < 2, reason="test requires multi-GPU machine")
74-
@pytest.mark.parametrize('cli_args', [ARGS_DDP, ARGS_DDP + ARGS_AMP])
75-
def test_examples_ddp(tmpdir, import_cli, cli_args):
76-
77-
module = importlib.import_module(import_cli)
78-
# update the temp dir
79-
cli_args = cli_args % {'tmpdir': tmpdir}
80-
81-
with mock.patch("argparse._sys.argv", ["any.py"] + cli_args.strip().split()):
82-
module.cli_main()
68+
# @pytest.mark.parametrize('import_cli', [
69+
# 'pl_examples.basic_examples.simple_image_classifier',
70+
# 'pl_examples.basic_examples.backbone_image_classifier',
71+
# 'pl_examples.basic_examples.autoencoder',
72+
# ])
73+
# @pytest.mark.skipif(torch.cuda.device_count() < 2, reason="test requires multi-GPU machine")
74+
# @pytest.mark.parametrize('cli_args', [ARGS_DDP, ARGS_DDP + ARGS_AMP])
75+
# def test_examples_ddp(tmpdir, import_cli, cli_args):
76+
#
77+
# module = importlib.import_module(import_cli)
78+
# # update the temp dir
79+
# cli_args = cli_args % {'tmpdir': tmpdir}
80+
#
81+
# with mock.patch("argparse._sys.argv", ["any.py"] + cli_args.strip().split()):
82+
# module.cli_main()
8383

8484

8585
@pytest.mark.parametrize('import_cli', [

0 commit comments

Comments
 (0)