Skip to content

Commit c53dc20

Browse files
authored
Make sure save_dir can be empty str (#15638)
1 parent 164e5a7 commit c53dc20

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/pytorch_lightning/callbacks/model_checkpoint.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,10 @@ def __resolve_ckpt_dir(self, trainer: "pl.Trainer") -> _PATH:
584584
return self.dirpath
585585

586586
if len(trainer.loggers) > 0:
587-
save_dir = trainer.loggers[0].save_dir or trainer.default_root_dir
587+
if trainer.loggers[0].save_dir is not None:
588+
save_dir = trainer.loggers[0].save_dir
589+
else:
590+
save_dir = trainer.default_root_dir
588591
name = trainer.loggers[0].name
589592
version = trainer.loggers[0].version
590593
version = version if isinstance(version, str) else f"version_{version}"

0 commit comments

Comments
 (0)